Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver-adapters-wasm): Adapt to post-engine split changes #4519

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Feb 6, 2024

  • Fix WASM engine check post-split

@SevInf SevInf changed the base branch from dev to integration February 6, 2024 17:46
@SevInf
Copy link
Contributor Author

SevInf commented Feb 6, 2024

Merge only after prisma/prisma#22957
And don't forget to change base branch to dev)

@millsp
Copy link
Member

millsp commented Feb 6, 2024

There are some legitimate errors that may need to be fixed in the originating PR.

@steebchen steebchen force-pushed the integration branch 10 times, most recently from 2e18d09 to 652d9d6 Compare February 8, 2024 09:44
@SevInf SevInf changed the base branch from integration to dev February 8, 2024 10:36
@SevInf SevInf marked this pull request as ready for review February 8, 2024 11:20
@Jolg42 Jolg42 added this to the 5.10.0 milestone Feb 8, 2024
@janpio
Copy link
Contributor

janpio commented Feb 8, 2024

Heroku error right now:

-----> Installing dependencies
       Installing node modules (package.json)
       npm ERR! code ECONNRESET
       npm ERR! errno ECONNRESET
       npm ERR! network Invalid response body while trying to fetch https://registry.npmjs.org/@prisma%2fget-platform: aborted
       npm ERR! network This is a problem related to network connectivity.
       npm ERR! network In most cases you are behind a proxy or have bad network settings.
       npm ERR! network 
       npm ERR! network If you are behind a proxy, please make sure that the
       npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
       
       npm ERR! A complete log of this run can be found in: /tmp/npmcache.oRYfO/_logs/2024-02-08T11_22_45_904Z-debug-0.log
-----> Build failed
       
       We're sorry this build is failing! You can troubleshoot common issues here:
       https://devcenter.heroku.com/articles/troubleshooting-node-deploys
       
       Some possible problems:
       
       - Node version not specified in package.json
         https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version
       
       - ECONNRESET issues may be related to npm versions
         https://github.com/npm/registry/issues/10#issuecomment-217141066
       
       Love,
       Heroku
       
 !     Push rejected, failed to compile Node.js app.
 !     Push failed

@Jolg42
Copy link
Contributor

Jolg42 commented Feb 12, 2024

I checked with @SevInf and we need to merge prisma/prisma#23047 and prisma/prisma-engines#4710 to unblock this.

@SevInf
Copy link
Contributor Author

SevInf commented Feb 14, 2024

I am going to merge this and address a remaining failure in follow-up PR.

@SevInf SevInf merged commit 9d965d1 into dev Feb 14, 2024
282 of 284 checks passed
@SevInf SevInf deleted the fix/split-engine branch February 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants