Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: nextjs update globalThis type declaration #5610

Merged
merged 4 commits into from
May 2, 2024

Conversation

decovicdev
Copy link
Contributor

Describe this PR

This PR addresses two issues:

  1. Fixes the ESLint error "All 'var' declarations must be at the top of the function scope" (eslint/vars-on-top)

  2. Extends globalThis to include the prisma property specifically for the db.ts file

Changes

Updated the declaration of globalThis to include the prisma property in a safe way.

What issue does this fix?

N/A

Any other relevant information

N/A

update `globalThis` include prisma only for db file
Copy link

vercel bot commented Feb 1, 2024

@decovicdev is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@decovicdev decovicdev marked this pull request as ready for review February 1, 2024 20:27
@decovicdev decovicdev changed the title :enhancement: update globalThis type only for db file :enhancement: nextjs update globalThis type declaration Feb 1, 2024
@decovicdev decovicdev changed the title :enhancement: nextjs update globalThis type declaration enhancement: nextjs update globalThis type declaration Feb 1, 2024
@jharrell jharrell merged commit 1e4a8b5 into prisma:main May 2, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants