Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: hidden prop on nav item #5484

Closed
wants to merge 2 commits into from
Closed

update: hidden prop on nav item #5484

wants to merge 2 commits into from

Conversation

nilubava
Copy link
Contributor

@nilubava nilubava commented Nov 22, 2023

#5477

Add prop hidden: true to hide any top nav item

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ❌ Failed (Inspect) Nov 24, 2023 1:10pm

@nilubava nilubava requested a review from nikolasburk November 22, 2023 13:45
Copy link
Contributor

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

Copy link
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilubava this looks great, thanks a lot!

I have one suggestion to remove the hidden flag from the About page because we want to keep it in the top-nav (for now).

config.ts Outdated Show resolved Hide resolved
@jharrell jharrell closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidenav breaks when top-level item gets hidden
3 participants