Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: read replicas #5467

Merged
merged 14 commits into from
Nov 23, 2023
Merged

docs: read replicas #5467

merged 14 commits into from
Nov 23, 2023

Conversation

ruheni
Copy link
Contributor

@ruheni ruheni commented Nov 17, 2023 •
edited
Loading

Closes #5441

@vercel Vercel
Copy link

vercel bot commented Nov 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 0:03am

@github-actions GitHub Actions
Copy link
Contributor

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions GitHub Actions
Copy link
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

@ruheni ruheni self-assigned this Nov 17, 2023
@ruheni ruheni marked this pull request as ready for review November 17, 2023 11:31
@ruheni ruheni requested review from janpio, SevInf and jharrell November 17, 2023 11:32
nikolasburk
nikolasburk approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, let's merge? (if we still find issues in this, we can also correct them )

jharrell
jharrell approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@jharrell jharrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but left some comments that I personally think should be changed. Happy to start a discussion. 😄

content/200-concepts/100-components/02-prisma-client/065-read-replicas.mdx Outdated Show resolved Hide resolved
content/200-concepts/100-components/02-prisma-client/065-read-replicas.mdx Outdated Show resolved Hide resolved
content/200-concepts/100-components/02-prisma-client/065-read-replicas.mdx Outdated Show resolved Hide resolved
content/200-concepts/100-components/02-prisma-client/065-read-replicas.mdx Outdated Show resolved Hide resolved
content/200-concepts/100-components/02-prisma-client/065-read-replicas.mdx Outdated Show resolved Hide resolved
content/200-concepts/100-components/02-prisma-client/065-read-replicas.mdx Outdated Show resolved Hide resolved
janpio
janpio approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait for review from the expert, @SevInf, before merging.

@janpio janpio removed the defer label Nov 23, 2023
@janpio janpio merged commit 87f9b4b into main Nov 23, 2023
5 of 6 checks passed
@janpio janpio deleted the read-replicas branch November 23, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharrell jharrell jharrell approved these changes

@nikolasburk nikolasburk nikolasburk approved these changes

@janpio janpio janpio approved these changes

@SevInf SevInf Awaiting requested review from SevInf

Assignees

@ruheni ruheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Read Replica support
4 participants
@ruheni @janpio @nikolasburk @jharrell