Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PgBouncer => external connection pooler #5427

Merged
merged 12 commits into from
Nov 23, 2023
Merged

feat: PgBouncer => external connection pooler #5427

merged 12 commits into from
Nov 23, 2023

Conversation

janpio
Copy link
Contributor

@janpio janpio commented Nov 6, 2023

Generalize in prep for upcoming PgBouncer changes.

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 10:44am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This PR probably requires the following redirects to be added to vercel.json:

  {
    "source": "/docs/guides/performance-and-optimization/connection-management/configure-pg-bouncer",
    "destination": "/docs/guides/performance-and-optimization/connection-management/configure-for-external-connection-pooler"
  },

@janpio janpio requested review from jharrell and ruheni November 15, 2023 14:52
@janpio janpio marked this pull request as ready for review November 15, 2023 14:52
ruheni
ruheni approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ruheni ruheni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've left minor comments. We can merge it once they're resolved and the merge conflict is also resolved

@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023

Deployment failed with the following error:

Could not parse File as JSON: vercel.json

@janpio janpio removed the defer label Nov 23, 2023
@janpio janpio merged commit 38e4f20 into main Nov 23, 2023
5 of 6 checks passed
@janpio janpio deleted the janpio/external-connection-pooler branch November 23, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruheni ruheni ruheni approved these changes

@jharrell jharrell Awaiting requested review from jharrell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janpio @ruheni @nikolasburk