Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for using SafeQL and extensions to help unsupported features. #5419

Merged
merged 34 commits into from
Nov 22, 2023

Conversation

jharrell
Copy link
Member

@jharrell jharrell commented Nov 2, 2023

No description provided.

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 8:12am

Copy link
Contributor

github-actions bot commented Nov 2, 2023

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

Copy link
Contributor

github-actions bot commented Nov 2, 2023

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

@jharrell jharrell changed the title add guide for GIS support Add guide for using SafeQL and extensions to help unsupported features. Nov 2, 2023
@nikolasburk nikolasburk requested a review from ruheni November 21, 2023 17:36
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went ahead and update the guide based on my previous feedback:

  • added a second operation to create PointOfInterest records in the DB
  • removed -gis from the file name
  • made sure the raw SQL actually works properly
  • removed prettier snippets
  • simplified extension code
  • small improvements and adjustments here and there

…pesafe-raw-sql/01-safeql.mdx

Co-authored-by: Alex Ruheni <[email protected]>
nikolasburk and others added 4 commits November 22, 2023 08:45
…pesafe-raw-sql/01-safeql.mdx

Co-authored-by: Alex Ruheni <[email protected]>
…pesafe-raw-sql/01-safeql.mdx

Co-authored-by: Alex Ruheni <[email protected]>
…pesafe-raw-sql/01-safeql.mdx

Co-authored-by: Alex Ruheni <[email protected]>
…pesafe-raw-sql/01-safeql.mdx

Co-authored-by: Alex Ruheni <[email protected]>
Copy link
Contributor

@ruheni ruheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few comments in there that should be addressed before merging.

Side note: overall, it reads more like a blog post than docs.

@nikolasburk nikolasburk merged commit a3f1d0b into main Nov 22, 2023
5 checks passed
@nikolasburk nikolasburk deleted the jharrell/issue5407 branch November 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover SafeQL usage within a client extension
5 participants