Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 400-nextjs-prisma-client-dev-practices.mdx #5384

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

zhandosm
Copy link
Contributor

  • Add extension to the db file as file=./db was a bit misleading Result: file=./db.ts

Describe this PR

  • The explanation for connection bets practices - Best practice for instantiating PrismaClient with Next.js has an exmpale file db with missing extension. This seemed a bit misleading because other parts on the docs have the extension. The screenshots as reference:
  • WIth extiension
    Screen Shot 2023-10-17 at 3 12 10 PM
  • without extension
    Screen Shot 2023-10-17 at 3 12 15 PM

Changes

  • Added extension to the file in the docs

- Add extension to the `db` file as file=./db was a bit misleading
Result: file=./db.ts
@vercel
Copy link

vercel bot commented Oct 17, 2023

@zhandosm is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

…articles/400-nextjs-prisma-client-dev-practices.mdx
Copy link
Contributor

@ruheni ruheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and resolving this. 🙏

I've gone ahead and removed the file path prefix, ./ to keep it consistent with the other example.

Copy link
Contributor

@ruheni ruheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and resolving this. 🙏

I've gone ahead and removed the file path prefix, ./ to keep it consistent with the other example.

@ruheni ruheni merged commit e920820 into prisma:main Oct 24, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants