add line highlighting in custom model examples #5097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links
(Note that links will only be valid after Vercel preview deploy succeeded) |
|
This PR probably requires the following redirects to be added to vercel.json:
|
ruheni
reviewed
Jul 25, 2023
| @@ -173,7 +173,7 @@ You can "rename" fields and models that are used in Prisma Client by mapping the | |||
|
|
|||
| _After_ you introspected your database with `prisma db pull`, you can manually adjust the resulting Prisma schema as follows: | |||
|
|
|||
| ```prisma | |||
| ```prisma highlight=1-2;edit|4;edit|5-6;add|9;edit|12-13;edit|16;add|19-20;edit|25-26;edit|27-28;add|31-32;edit|35;edit|36-27;add|40-41;edit|44-45;edit|46-47;add | |||
There was a problem hiding this comment.
The code snippet is too chaotic, and hard to follow the changes. I would suggest either:
- Using tabs — one tab containing the updates and the other one for the final schema (no highlights)
- A combo of a comment (right above the relation field) and highlight for the section with the
@@map("")attribute function - Using a simpler (our standard) schema with the Post & User models
|
I'm not sure this PR is an improvement, it's very noisy indeed. At this point, I'd probably prefer not using any highlights and keep the code snippet plain. If you still feel strongly about line highlighting here, let's discuss on Slack how to best go about this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815