Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Prisma Client installation and client generation with migrate dev #4724

Merged
merged 16 commits into from
Nov 24, 2023

Conversation

Alwoch
Copy link
Contributor

@Alwoch Alwoch commented May 1, 2023

Description

  • Include information about Prisma Client installation and client generation as a part of what happens when migrate dev is run

@vercel
Copy link

vercel bot commented May 1, 2023

@Alwoch is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@ruheni
Copy link
Contributor

ruheni commented May 4, 2023

Hey 👋

When prisma migrate dev is run the first time, Prisma Client is installed and generated under the hood. Did you run into an error? I would be happy to get your feedback running through the quickstart and any challenges you ran into. 🙂

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the auto install of Prisma Client during generate we currently prefer not to document this as an additional step.

If the auto install does not work for you, that deserves a bug report. Thanks.

@Alwoch
Copy link
Contributor Author

Alwoch commented May 9, 2023

I appreciate your guidance on this @ruheni @janpio and I've made the suggested changes

@janpio janpio self-requested a review May 10, 2023 21:59
@Alwoch Alwoch changed the title Add instructions to install Prisma Client Add clarifications about regenerating Prisma Client after modifying models Oct 30, 2023
ruheni
ruheni previously approved these changes Oct 30, 2023
Copy link
Contributor

@ruheni ruheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates! 🙏

@ruheni ruheni dismissed their stale review October 30, 2023 13:20

Making a few more edits

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is at least under the wrong headline.
Generally I am not sure if it fits the flow of the quickstart.

@Alwoch Alwoch changed the title Add clarifications about regenerating Prisma Client after modifying models Include Prisma Client generation with migrate dev Oct 31, 2023
@Alwoch Alwoch changed the title Include Prisma Client generation with migrate dev Include Prisma Client installation and client generation with migrate dev Oct 31, 2023
@Alwoch
Copy link
Contributor Author

Alwoch commented Oct 31, 2023

This is at least under the wrong headline. Generally I am not sure if it fits the flow of the quickstart.

@janpio I've made some changes, Kindly take a look.

@nikolasburk nikolasburk requested a review from janpio November 23, 2023 09:40
@janpio janpio requested a review from nikolasburk November 23, 2023 12:18
@nikolasburk nikolasburk merged commit 6915789 into prisma:main Nov 24, 2023
2 of 3 checks passed
@nikolasburk
Copy link
Member

Hey @Alwoch, sorry this took so long and thank you so much for taking the time to help us improve our docs 💚 that's much appreciated!!

@Alwoch Alwoch deleted the edit_01-quickstart.mdx branch November 24, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants