Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATFORM-1795]: Ensure observability is strong for migration #64

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

---

## [0.8.0] - 2024-06-21

## Changed

- **Breaking**: `with_country` will now add the `prima_country` tag instead of `prima:country`

---

## [0.7.2] - 2024-05-03

### Added
Expand Down Expand Up @@ -142,7 +150,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.1.5]


[Unreleased]: https://github.com/primait/prima_datadog.rs/compare/0.7.2...HEAD

[Unreleased]: https://github.com/primait/prima_datadog.rs/compare/0.8.0...HEAD
[0.8.0]: https://github.com/primait/prima_datadog.rs/compare/0.7.2...0.8.0
[0.7.2]: https://github.com/primait/prima_datadog.rs/compare/0.7.1...0.7.2
[0.7.1]: https://github.com/primait/prima_datadog.rs/compare/0.7.0...0.7.1
[0.7.0]: https://github.com/primait/prima_datadog.rs/compare/0.7.0...0.7.0
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description = "An opinionated library to share code and approach to Datadog logg
edition = "2018"
license = "MIT"
name = "prima_datadog"
version = "0.7.2"
version = "0.8.0"

[features]
default = []
Expand Down
4 changes: 2 additions & 2 deletions src/configuration/country.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,14 @@ mod tests {
.with_from_addr("from_addr")
.with_country(Country::It);

assert_eq!(config.default_tags(), vec!["prima:country:it"]);
assert_eq!(config.default_tags(), vec!["prima_country:it"]);

let config = Configuration::new("to_addr", "namespace")
.with_from_addr("from_addr")
.with_country(Country::It)
.with_country(Country::Es);

// Datadog tag keys are allowed to map to multiple values, and I suppose we're ok with that too (e.g. cross-country infra down the line?)
assert_eq!(config.default_tags(), vec!["prima:country:it", "prima:country:es"]);
assert_eq!(config.default_tags(), vec!["prima_country:it", "prima_country:es"]);
}
}
2 changes: 1 addition & 1 deletion src/configuration/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ impl Configuration {
}

pub fn with_country(self, country: Country) -> Self {
self.with_tag("prima:country", &country)
self.with_tag("prima_country", &country)
}

pub fn with_tracker_configuration(mut self, tracker: TagTrackerConfiguration) -> Self {
Expand Down