Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayamaster
approved these changes
Dec 3, 2023
khj0426
approved these changes
Dec 3, 2023
…m-12-ReviewRanger-FE into REV-399/활성화된-탭-페이지-이동-시에도-고정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 구현 내용
임시 방편으로
TabsProvider를 만들어 적용해주었습니다.단점: 이왕이면
useTabs훅을 좀 더 범용적으로 만들고 싶었지만, 시간 한계가 있어 일단 메인 페이지의 탭을 위주로 만들었습니다.사실 Header와 Tab을 아예 밖으로 빼고 싶은 생각이 있습니다.
추후 리팩토링 때 좀 더 시간을 들여서 밖으로 빼고 더 확장성 있게 다시 구현하려고 합니다!
🚧 참고 사항