Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ExLLama v2 #90

Merged
merged 26 commits into from
Dec 8, 2023
Merged

Support for ExLLama v2 #90

merged 26 commits into from
Dec 8, 2023

Conversation

Anindyadeep
Copy link
Member

Solves issue #73

@Anindyadeep Anindyadeep marked this pull request as draft December 7, 2023 12:00
@Anindyadeep Anindyadeep self-assigned this Dec 8, 2023
@Anindyadeep Anindyadeep requested a review from nsosio December 8, 2023 07:52
@Anindyadeep Anindyadeep marked this pull request as ready for review December 8, 2023 07:53
@Anindyadeep Anindyadeep added the enhancement New feature or request label Dec 8, 2023
nsosio
nsosio reviewed Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@nsosio nsosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove code changes to pytorch (let's merge PRs to master and then merge master to the new PRs branches)
  • what about CPU/Metal tables, is there no support?

@Anindyadeep
Copy link
Member Author

  • remove code changes to pytorch (let's merge PRs to master and then merge master to the new PRs branches)
  • what about CPU/Metal tables, is there no support?
  1. Yep, just merged the pytorch into main and merged those changes into this branch.
  2. I ran into mac, and got this error:
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.

This means by default exllamav2 looks for cuda, this mean that it does not run into CPU. Also, the main repo also mentions it is meant for GPUs.

@Anindyadeep Anindyadeep requested a review from nsosio December 8, 2023 09:42
@nsosio
Copy link
Collaborator

nsosio commented Dec 8, 2023

@Anindyadeep let's solve the conflicts and we can merge it :)

@nsosio nsosio merged commit 13bf323 into premAI-io:main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsosio nsosio nsosio approved these changes

Assignees

@Anindyadeep Anindyadeep

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anindyadeep @nsosio