Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of 'connecting' sync status from Dart SDK #434

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

LucDeCaf
Copy link
Contributor

@LucDeCaf LucDeCaf commented Dec 6, 2024

Implementation of the SyncStatus.connecting flag in the Dart SDK as SyncStatus.connecting() and SyncStatusOptions.connecting?: boolean in SyncStatusOptions.

NB: If connected === true then connecting === false always.

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: f1eb79c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@powersync/common Minor
@powersync/op-sqlite Patch
@powersync/react-native Patch
@powersync/tanstack-react-query Patch
@powersync/web Patch
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LucDeCaf LucDeCaf marked this pull request as draft December 6, 2024 15:38
@LucDeCaf
Copy link
Contributor Author

LucDeCaf commented Dec 6, 2024

Putting this here for myself later.

TODOS (all done now)

  • Find all modifications to SyncStatus.connected and check if SyncStatus.connecting should also be modified
  • Find all places where the shape of SyncStatus is important and check if it supports SyncStatus.connecting
  • Build package and test SyncStatus.connecting

@LucDeCaf LucDeCaf marked this pull request as ready for review December 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant