-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] OP SQLite Adapter for PowerSync #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c698c07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
reviewed
Sep 11, 2024
- Upgrade RN supabase todolist dependencies
benitav
reviewed
Oct 10, 2024
…into poc/op-sqlite
stevensJourney
previously approved these changes
Oct 10, 2024
stevensJourney
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work includes the introduction of a OP SQLite factory that can be used when creating a PowerSync database. This will be opt-in by default allowing the user to install an additional dependency in order to use OP SQLite rather than react-native-quick-sqlite. The
@op-engineering/op-sqlite
dependency can not installed side by side with@journeyapps/react-native-quick-sqlite
as the compiled sqlite binaries conflict.This will allow us to eventually support React Native's new architecture which requires native modules to be upgraded to the newer Turbo module system. OP SQLite supports new architecture by default.
Example
This is how initializing a new PowerSync database currently works and how it will work using the new OP SQLite factory.
RNQS:
OP SQLite:
Shoutout to @stevensJourney for laying out majority of the groundwork.
Testing
The package was tested manually in the
react-native-supabase-todolist
demo.TODO
Tests(Will be done in the next release)