Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add common as peer dependency to packages #171

Merged
merged 3 commits into from
May 17, 2024

Conversation

DominicGBauer
Copy link
Collaborator

@DominicGBauer DominicGBauer commented May 16, 2024

Description

Add common to peerDependency of packages so that users are warned if common is mismatched under breaking change.

There is no need to have common a dependency anymore as peerDeps are auto installed in npm and pnpm and a warning is given in yarn.

Example warning in NPM and Yarn (using an example from the internet):
image

image

Notes:

Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DominicGBauer DominicGBauer merged commit 6b01811 into main May 17, 2024
3 checks passed
@DominicGBauer DominicGBauer deleted the chore/add-peer-deps branch May 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants