Skip to content

Commit

Permalink
Removed override keyword usage, removed prepareQuery implementation…
Browse files Browse the repository at this point in the history
… from PSSqliteSession.
  • Loading branch information
Chriztiaan committed Jan 16, 2025
1 parent 81a1807 commit f783ecc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class PowerSyncSQLiteBaseSession<
protected logger: Logger;

constructor(
private db: LockContext,
protected db: LockContext,
protected dialect: SQLiteAsyncDialect,
protected schema: RelationalSchemaConfig<TSchema> | undefined,
protected options: PowerSyncSQLiteSessionOptions = {}
Expand All @@ -66,7 +66,7 @@ export class PowerSyncSQLiteBaseSession<
);
}

override transaction<T>(
transaction<T>(
_transaction: (tx: PowerSyncSQLiteTransaction<TFullSchema, TSchema>) => T,
_config: PowerSyncSQLiteTransactionConfig = {}
): T {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class PowerSyncSQLiteDatabase<
this.db = db;
}

override transaction<T>(
transaction<T>(
transaction: (
tx: SQLiteTransaction<'async', QueryResult, TSchema, ExtractTablesWithRelations<TSchema>>
) => Promise<T>,
Expand Down
20 changes: 1 addition & 19 deletions packages/drizzle-driver/src/sqlite/PowerSyncSQLiteSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,25 +32,7 @@ export class PowerSyncSQLiteSession<
this.client = db;
}

prepareQuery<T extends PreparedQueryConfigBase & { type: 'async' }>(
query: Query,
fields: SelectedFieldsOrdered | undefined,
executeMethod: SQLiteExecuteMethod,
isResponseInArrayMode: boolean,
customResultMapper?: (rows: unknown[][], mapColumnValue?: (value: unknown) => unknown) => unknown
): PowerSyncSQLitePreparedQuery<T> {
return new PowerSyncSQLitePreparedQuery(
this.client,
query,
this.logger,
fields,
executeMethod,
isResponseInArrayMode,
customResultMapper
);
}

override transaction<T>(
transaction<T>(
transaction: (tx: PowerSyncSQLiteTransaction<TFullSchema, TSchema>) => T,
config: PowerSyncSQLiteTransactionConfig = {}
): T {
Expand Down

0 comments on commit f783ecc

Please sign in to comment.