Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the MANIFEST.in file #240

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update the MANIFEST.in file #240

merged 1 commit into from
Dec 5, 2024

Conversation

pgiraud
Copy link
Member

@pgiraud pgiraud commented Nov 27, 2024 •
edited
Loading

No description provided.

@rjuju
Copy link
Member

rjuju commented Nov 28, 2024

Is the draft status on purpose?

@pgiraud
Copy link
Member Author

pgiraud commented Nov 28, 2024

Yes, I'm not 100% sure which files should be included or excluded. But if it looks good to you or you think this is harmless (better more than not enough), feel free to mark as ready and merge.

rjuju
rjuju requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@rjuju rjuju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also unsure of what to ship but the developer-tool related files should probably be ignored. I had no idea that this file existed or what it's used for so I don't really have an opinion apart from that.

Also, it seems to me that this is including #239, so you should add @brainexe as co-author. He's also more likely to have a better insights on this than me :)

MANIFEST.in Outdated Show resolved Hide resolved
@pgiraud
Copy link
Member Author

pgiraud commented Nov 28, 2024

@brainexe I improved your proposal from #239 and put you as a co-author. Could you please have a quick look and tell us if you agree with the changes?

@pgiraud pgiraud marked this pull request as ready for review November 28, 2024 11:37
@rjuju
Copy link
Member

rjuju commented Nov 28, 2024

FTR I checked on upstream debian package for powa-web, and apart from the setup.py __VERSION__ fix there is no extra patch, so the way they generate packages doesn't hit the same problem.

rjuju
rjuju requested changes Nov 28, 2024
View reviewed changes
MANIFEST.in Outdated Show resolved Hide resolved
@brainexe
Copy link
Contributor

I just rebuilt the version with the new manifest and it looks all good, needed files are all present for me. 👍

@pgiraud @brainexe
Update the MANIFEST.in file
f6cd7d7 
We include built asset files (in static/dist).
We exclude files that are only useful for dev.

We also add a CI job to check the Manifest.

Co-authored-by: Matthias Dötsch <[email protected]>
rjuju
rjuju reviewed Nov 29, 2024
View reviewed changes
MANIFEST.in Show resolved Hide resolved
@pgiraud pgiraud merged commit 79791e3 into master Dec 5, 2024
2 checks passed
@pgiraud pgiraud deleted the manifest_update branch December 5, 2024 09:35
@pgiraud pgiraud mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjuju rjuju rjuju requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgiraud @rjuju @brainexe