Fix indentation in headers with pgindent #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitcpp
changed the title
vitcpp
changed the title
esabol
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
I'm not a fan of adding extern to all the function prototypes in the header files (function prototypes are already implicitly extern in header files), but there's nothing incorrect about it, obviously. It's just a style preference thing and, if that's your preference, it's fine with me.
|
@esabol pgindent requires the extern specifier in the beginning of the function declaration. Otherwise, it reformats function declarations in a wrong way. Once this PR is applied, pgindent will not produce new changes for headers. |
This rule executes pgindent with header files only.
vitcpp
force-pushed
the
format-code-with-pgindent-headers
branch
from
1bbb81c to
d7ce1ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.