-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add playwright to simulator-ui #45
Conversation
not sure why there's so much stuff removed from package-lock.json. npm install didn't work for me, so maybe that's why? |
@@ -116,7 +116,9 @@ Desktop.ini | |||
.eslintcache | |||
|
|||
###################### | |||
# Code coverage | |||
# Test results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Test results | |
# Test artefacts |
simulator-ui/playwright.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die Kommentare, welche nicht unbedingt notwendig sind, können gelöscht werden.
test('should have total, successful, failed tabs', async ({page}) => { | ||
await page.goto('http://localhost:9000/'); | ||
|
||
await expect(page.getByText('Total:')).toBeVisible(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diese Selektoren können noch etwas präziser sein.
|
||
test('total, successful, failed tabs should display percentage in simulations count', async ({page}) => { | ||
await page.route('*/**/api/test-results/count-by-status', async route => { | ||
const json = {"successful": 746039, "failed": 490, "total": 746529}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hier könnten noch etwas einfachere Zahlen verwendet werden.
test('should click Details button', async ({page}) => { | ||
await page.goto('http://localhost:9000/scenario-result/'); | ||
|
||
await expect(page.getByText('Items per Page')).toBeVisible(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dieser Test sollte noch erweitert oder in den nächsten integriert werden.
await expect(page).toHaveTitle(/Citrus Simulator/); | ||
}); | ||
|
||
test('should have refresh list, and reset button', async ({page}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dieser und der nächste Test können zusammengeführt werden.
superseded by #46. |
No description provided.