fix(citrus-simulator-ui): fix linter and prettier

postfinance · Sep 26, 2024 · ce1464a · ce1464a
1 parent 59bdc79
commit ce1464a
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 25 deletions.
diff --git a/simulator-ui/src/main/webapp/app/app.module.ts b/simulator-ui/src/main/webapp/app/app.module.ts
@@ -1,5 +1,5 @@
 import { registerLocaleData } from '@angular/common';
-import {HTTP_INTERCEPTORS, provideHttpClient, withInterceptorsFromDi} from '@angular/common/http';
+import { HTTP_INTERCEPTORS, provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 import locale from '@angular/common/locales/en';
 import { LOCALE_ID, NgModule } from '@angular/core';
 import { BrowserModule, Title } from '@angular/platform-browser';
@@ -41,9 +41,7 @@ import MainModule from './layouts/main/main.module';
     TranslationModule,
   ],
   providers: [
-    provideHttpClient(
-      withInterceptorsFromDi(),
-    ),
+    provideHttpClient(withInterceptorsFromDi()),
     Title,
     { provide: LOCALE_ID, useValue: 'en' },
     { provide: NgbDateAdapter, useClass: NgbDateDayjsAdapter },

diff --git a/simulator-ui/tests/error-banner.spec.ts b/simulator-ui/tests/error-banner.spec.ts
@@ -1,29 +1,25 @@
 import { expect, Page, test } from '@playwright/test';
-import {
-  mockResponseForAllNavbarLinkedSites, navbarElementLinkPairs
-} from './helpers/helper-functions';
-import {NavbarElementLinkPair} from "./helpers/helper-interfaces";
+import { mockResponseForAllNavbarLinkedSites, navbarElementLinkPairs } from './helpers/helper-functions';
+import { NavbarElementLinkPair } from './helpers/helper-interfaces';
 
 const goToSiteAndVerifyErrorBannerIsVisible = (site: NavbarElementLinkPair): void => {
   test(`${site.testName}`, async ({ page }) => {
-    if(site.apiLink && site.linkSuffix) {
+    if (site.apiLink && site.linkSuffix) {
       await mock500ErrorResponseForApiURL(page, site.apiLink);
       await page.goto(`http://localhost:9000${site.linkSuffix}`);
       await expect(page.getByTestId('error')).toBeVisible();
     }
   });
-}
-
-
+};
 
-test.describe('should show error banner if there is a 500 error returned while loading any page', async () => {
+test.describe('should show error banner if there is a 500 error returned while loading any page', () => {
   test.beforeEach(async ({ page }) => {
     await mockResponseForAllNavbarLinkedSites(page, mock500ErrorResponseForApiURL);
   });
 
   navbarElementLinkPairs.forEach((element: NavbarElementLinkPair) => {
-    if(element.childElements){
-      for(const child of element.childElements){
+    if (element.childElements) {
+      for (const child of element.childElements) {
         goToSiteAndVerifyErrorBannerIsVisible(child);
       }
     }
@@ -35,7 +31,7 @@ const mock500ErrorResponseForApiURL = async (page: Page, apiLink: string): Promi
   await page.route(apiLink, async route => {
     await route.fulfill({
       status: 500,
-      body: JSON.stringify({"message": "hello"}),
+      body: JSON.stringify({ message: 'hello' }),
     });
   });
 };
diff --git a/simulator-ui/tests/helpers/helper-functions.ts b/simulator-ui/tests/helpers/helper-functions.ts
@@ -4,28 +4,53 @@ import { NavbarElementLinkPair } from './helper-interfaces';
 // a list of every navbar link-pair, which appears under the "Entity" dropdown
 export const entityChildLinks: NavbarElementLinkPair[] = [
   { testName: 'navigationEntitiesMessageLink', expectedLinkRegex: /.*\/message*/, linkSuffix: '/message', apiLink: '**/api/messages*' },
-  { testName: 'navigationEntitiesMessageHeaderLink', expectedLinkRegex: /.*\/message-header*/, linkSuffix: '/message-header', apiLink: '**/api/message-headers*' },
+  {
+    testName: 'navigationEntitiesMessageHeaderLink',
+    expectedLinkRegex: /.*\/message-header*/,
+    linkSuffix: '/message-header',
+    apiLink: '**/api/message-headers*',
+  },
   {
     testName: 'navigationEntitiesScenarioExecutionLink',
     expectedLinkRegex: /.*\/scenario-execution*/,
     linkSuffix: '/scenario-execution',
     apiLink: '**/api/scenario-executions*',
   },
-  { testName: 'navigationEntitiesScenarioActionLink', expectedLinkRegex: /.*\/scenario-action*/, linkSuffix: '/scenario-action', apiLink: '**/api/scenario-actions*' },
+  {
+    testName: 'navigationEntitiesScenarioActionLink',
+    expectedLinkRegex: /.*\/scenario-action*/,
+    linkSuffix: '/scenario-action',
+    apiLink: '**/api/scenario-actions*',
+  },
   {
     testName: 'navigationEntitiesScenarioParameterLink',
     expectedLinkRegex: /.*\/scenario-parameter*/,
     linkSuffix: '/scenario-parameter',
     apiLink: '**/api/scenario-parameters*',
   },
-  { testName: 'navigationEntitiesTestResultLink', expectedLinkRegex: /.*\/test-result*/, linkSuffix: '/test-result', apiLink: '**/api/test-results*' },
-  { testName: 'navigationEntitiesParameterLink', expectedLinkRegex: /.*\/test-parameter*/, linkSuffix: '/test-parameter', apiLink: '**/api/test-parameters*' },
+  {
+    testName: 'navigationEntitiesTestResultLink',
+    expectedLinkRegex: /.*\/test-result*/,
+    linkSuffix: '/test-result',
+    apiLink: '**/api/test-results*',
+  },
+  {
+    testName: 'navigationEntitiesParameterLink',
+    expectedLinkRegex: /.*\/test-parameter*/,
+    linkSuffix: '/test-parameter',
+    apiLink: '**/api/test-parameters*',
+  },
 ];
 
 // a list of every navbar element, which leads directly to another page
 export const navbarElementLinkPairs: NavbarElementLinkPair[] = [
   { testName: 'navigationScenariosLink', expectedLinkRegex: /.*\/scenario*/, linkSuffix: '/scenario', apiLink: '**/api/scenarios*' },
-  { testName: 'navigationScenarioExecutionsLink', expectedLinkRegex: /.*\/scenario-result*/, linkSuffix: '/scenario-result',apiLink: '**/api/scenario-executions*' },
+  {
+    testName: 'navigationScenarioExecutionsLink',
+    expectedLinkRegex: /.*\/scenario-result*/,
+    linkSuffix: '/scenario-result',
+    apiLink: '**/api/scenario-executions*',
+  },
   { testName: 'navigationEntitiesLink', childElements: entityChildLinks },
 ];
 
@@ -60,7 +85,10 @@ export const mockBackendResponse = async (
   });
 };
 
-export const mockResponseForAllNavbarLinkedSites = async (page: Page, responseMockFunction: (page: Page, apiLink: string) => Promise<void>): Promise<void> => {
+export const mockResponseForAllNavbarLinkedSites = async (
+  page: Page,
+  responseMockFunction: (page: Page, apiLink: string) => Promise<void>,
+): Promise<void> => {
   for (const element of navbarElementLinkPairs) {
     if (element.childElements) {
       for (const child of element.childElements) {

diff --git a/simulator-ui/tests/no-data.spec.ts b/simulator-ui/tests/no-data.spec.ts
@@ -2,11 +2,11 @@ import { expect, Page, test } from '@playwright/test';
 import {
   goToAllNavigationTabsAndOptionallyValidateContent,
   mockBackendResponse,
-  mockResponseForAllNavbarLinkedSites
+  mockResponseForAllNavbarLinkedSites,
 } from './helpers/helper-functions';
 
 test.beforeEach(async ({ page }) => {
-  await mockResponseForAllNavbarLinkedSites(page, mockEmptyResponseForApiURL)
+  await mockResponseForAllNavbarLinkedSites(page, mockEmptyResponseForApiURL);
   await page.goto('http://localhost:9000/');
 });
 
@@ -19,5 +19,5 @@ const verifyNoDataFoundBannerIsVisible = async (page: Page): Promise<void> => {
 };
 
 const mockEmptyResponseForApiURL = async (page: Page, apiLink: string): Promise<void> => {
-  await mockBackendResponse(page, apiLink, [], { 'x-total-count': '0' })
+  await mockBackendResponse(page, apiLink, [], { 'x-total-count': '0' });
 };