Make the cmd-line args match cowsay's usage #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed settings wrapping width with `-W` instead of `-w`. * implemented missing arg `-n` to disable line wrapping * Changed existing `-n` to `-N` to avoid conflict
|
Just use the cow files instead of pokemonsay. |
AnthonyVadala
added a commit
to AnthonyVadala/pokemonsay
that referenced
this pull request
Apr 27, 2022
Includes changes from open pull requests on possatti / pokemonsay possatti#20 possatti#15 possatti#11 possatti#10 possatti#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I looked for the
-noptions to disable line wrapping and found that it wasn't in pokemonsay. I find it useful so that quotes/poems etc. don't have weird line wrapping that makes them a little awkward to read.Changes
-Winstead of-w.-nto disable line wrapping-nto-Nto avoid conflictCaveats
This does break the existing usage of
-n("don't print pokémon name) and-w(line-wrap width), but I decided that trying to match the existing cowsay args first might be a good approach.'I'm happy to keep the existing args if that is more desirable 👍 .