fix: save with latest google chrome #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 42 42
Lines 4681 4683 +2
=======================================
+ Hits 4043 4045 +2
Misses 638 638 ☔ View full report in Codecov by Sentry. |
|
@rich-iannone do you mind checking the uploaded screenshots when you review? They're tucked intot he "Test for saving table image..." gh action...
|
|
When it's time, let's squash and merge this so the orphan commit isn't in our history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #424
The challenge was that our resizing set the browser outer dimensions, but this does not account for space taken up by browser UI elements (which vary by browser). We had a "crud factor" set that basically accounted for this space by blissful accident.
.save()now explicitly tries to calculate the space between outer and inner browser dimensions, with a much smaller crud factor (to create some small padding around the table. This is important because table borders without crud factor might cause issues).