Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added different modulations in signal generator #2492

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

daviderud
Copy link
Contributor

Added DSB, AM 100% mod index and AM 50% mod index. Changed UI.

image

Added DSB, AM 100% mod index and AM 50% mod index. Changed UI.
@gullradriel gullradriel self-requested a review January 25, 2025 15:07
@gullradriel
Copy link
Member

Hello @daviderud .
Thanks for the contributions.
Please apply proper formatting by running format-code.sh at the root of your clone. Commit the changes so the checks can pass.

@gullradriel
Copy link
Member

proc_siggen.cpp is not correctly formatted.
Maybe you forgot to commit after caller format-code.sh ?

@daviderud
Copy link
Contributor Author

For some reason VS Code in windows do not perform any format correction in the proc_siggen.cpp . Had to run the sh script on a linux virtual machine...
I will try to see if I manage to add the clang in the docker so that the script can be run from there in Windows.

@gullradriel
Copy link
Member

I relaunched the checks, we will see if all is good :-)

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks !

@gullradriel
Copy link
Member

I think we are going to bypass firmware limits with that PR.
Please wait a bit that we externalize one or two more apps before we merge.

@daviderud
Copy link
Contributor Author

daviderud commented Jan 26, 2025 via email

@gullradriel gullradriel merged commit 520ad97 into portapack-mayhem:next Jan 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants