Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(refactor): Modal close refactor, helmet async, rm react-scroll #2412

Merged
merged 8 commits into from
Jan 5, 2025
Merged

feat(refactor): Modal close refactor, helmet async, rm react-scroll #2412

merged 8 commits into from
Jan 5, 2025

Conversation

rossbulat
Copy link
Collaborator

@rossbulat rossbulat commented Jan 5, 2025 •
edited
Loading

  • refactors ModalClose to be inline with ui-core and ui-overlay packages.
  • uses react-helmet-async instead of react-helmet.
  • removes react-scroll.

@rossbulat rossbulat changed the title feat(refacotr) Modal close refactor feat(refactor): Modal close refactor Jan 5, 2025
@rossbulat rossbulat changed the title feat(refactor): Modal close refactor feat(refactor): Modal close refactor, helmet async, rm react-scroll Jan 5, 2025
@rossbulat rossbulat merged commit 7977231 into main Jan 5, 2025
7 checks passed
@rossbulat rossbulat deleted the rb-modal-close-refactor branch January 5, 2025 12:27
@rossbulat rossbulat mentioned this pull request Jan 5, 2025
Merged
@rossbulat rossbulat mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Post Funding 24/25 Ref
Projects
Staking Dashboard 1.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rossbulat