Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Ledger support improvements + bug fixes #1594

Merged
merged 45 commits into from
Nov 6, 2023
Merged

refactor: Ledger support improvements + bug fixes #1594

merged 45 commits into from
Nov 6, 2023

Conversation

rossbulat
Copy link
Collaborator

@rossbulat rossbulat commented Nov 3, 2023 •
edited
Loading

This PR iterates Ledger support and improves syntax of the Ledger contexts.

  • Handle one task at a time; take a task instead of an array of tasks.
  • Introduce dedicated DeviceIsBusy error.
  • Refactor errors into keyed types and improve readability of handling errors.
  • Introduce checkRuntimeVersion when making calls to Ledger. Store in ref whether runtimes are not in sync.
  • Refactor Tx to handle multi-stage flow for signing Ledger transactions. Call getRuntimeVersion in first step.
  • Check runtime version in Ledger Confirm stage and display warning if metadata is different version.
  • Move all Ledger HID i/o to a static class.
  • Split ledger context into LedgerHardware and LedgerAccounts.
  • Add "Ledger Account Imported" notification on successful import.
  • Tests
  • New translations

Misc fixes

  • Adds transferrable balance to TransferOptions, uses instead of free balance where applicable.

Ross Bulat added 30 commits November 3, 2023 15:19
refactor error handling
15b1138
reorganise some context syntax
5e12cd1
more ledger context tidy up
7cb12a8
accept one task, minimise executeLedgerLoop
e49dd1f
expand chainState
47eeaee
import
3799ce3
add runtimesInconsistent ref, checkRuntimeVersion
84861f5
rm getRuntimeVersion from sign_tx
76072fc
add integrityChecked
f89e895
don't reset txFees on mount
7dc1769
setIntegrityChecked on tx reset
12dfcd9
refactor Ledger submit, inner Tx element
1d9d06a
disabled as prop, LedgerSubmitProps
0705c91
work on ledger feedback
36aaef2
simplify handleGetAddress
55948e6
refactor remaining calls
7df0eec
rm ensureTransportClosed
0fe5156
rm deprecated state
df27125
use handleResetLedgerTx
4448ea0
simplify handleUnmount
7de3366
reformat status codes
a082a11
fixes
1e95634
separate ledger accounts from hardware management
912381d
mv useEffect over to ledger accounts
c7c3229
some tidy up
9f86b43
rm duplicate isExecuting
e9b2c76
only use latest status code
865670b
improvements to syntax
70e34d4
Merge branch 'main' into rb-ledger-version
1aa44a8
remove unneeded isMounted code
8dcacd4
@rossbulat rossbulat changed the title refactor: Ledger support improvements [WIP] refactor: Ledger support improvements Nov 5, 2023
@rossbulat rossbulat marked this pull request as ready for review November 5, 2023 13:54
@rossbulat
Copy link
Collaborator Author

@TingALin Would you be able to do translations for this PR?

@rossbulat rossbulat merged commit 491e178 into main Nov 6, 2023
6 checks passed
@rossbulat rossbulat deleted the rb-ledger-version branch November 6, 2023 05:35
@rossbulat rossbulat changed the title refactor: Ledger support improvements refactor: Ledger support improvements + bug fixes Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossbulat @TingALin