dst: bug and test fixes #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, some goroutines from the previous store (like block persistence) could race with the new store. This is an artifact of restarting the DB in-process. The approach used is to simply scan the running goroutine stacks, ignoring any goroutines that existed at the start of the test.
Previously, runtime.Gosched was called. However, this could be an issue in deterministic simulation tests since if other goroutines are sleeping, the yielding goroutine will schedule itself before advancing faketime. Sleeping is a quick fix for avoiding getting into this infinite loop, although we should probably come up with a long-term fix for these types of cases.
We were closing the incorrect column store at the end of the test (in some cases double closing).
asubiotto
force-pushed
the
alfonso-dstfixes
branch
from
addda1e to
2ee88fe
Compare
thorfour
approved these changes
May 21, 2024
…persisted Previously, the code attempted to do this by resetting the active block index. However, the ULID was left untouched. This would cause a previously persisted block to lose data when the new empty block's rotation happened. This commit updates the full block when a NewTableBlock entry is found and the table exists.
These log messges were useful when debugging DST failures.
asubiotto
force-pushed
the
alfonso-dstfixes
branch
from
2ee88fe to
432fa39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains miscellaneous test and bug fixes. See commits for details. This should fix all DST failures so far (run under stress for 100 iterations).