Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pqarrow/arrowutils: Add SortRecord and ReorderRecord #628
pqarrow/arrowutils: Add SortRecord and ReorderRecord #628
Changes from all commits
672bc29
e61df89
382716b
1c6f0f7
50fbae2
016693d
4388a71
9330d14
a8d72be
45656d8
e715049
ae01333
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I also wanted to note, this will work majority of the time. We support dictionaries and there is no dictionary kernel for
Take
yet.We need to optimise
compute.Take
on hte recordcompute.Take
on individual non dictionary columns and fall back to manual taking for the dictionary and then assembling the record (preferably concurrently).This can be done on a separate PR. Unless I'm mistaken, the PR just adds these functions but there is no expected call site for them in yet( There will be a need for a lot of changes for this to be used in my logictest PR).
I'm on mobile now , so I cant write what is needed for the logictest to use these functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's nasty and a really good comment!
We should make sure this is supported in follow-up PRs!