Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Swift 6 warnings #224

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Fix some Swift 6 warnings #224

merged 10 commits into from
Jun 12, 2024

Conversation

stephencelis
Copy link
Member

We have a couple warnings when building in Xcode 16.

@stephencelis stephencelis requested a review from mbrandonw June 12, 2024 20:18
@stephencelis
Copy link
Member Author

@finestructure While updating things for the beta, we realized that --static-swift-stdlib has been broken on Swift 5.9+ for awhile now. The failures are a little cryptic and we're not sure how to fix, so I'm removing it from CI for now, but if you still have a need to support it, we'd be happy to take a new PR to fix!

@stephencelis stephencelis merged commit 00bc30c into main Jun 12, 2024
5 checks passed
@stephencelis stephencelis deleted the swift-6 branch June 12, 2024 21:42
@finestructure
Copy link
Contributor

Thanks for the ping, @stephencelis ! Broken how? Because we're still using the flag in our linux builds (although in a project where we don't yet use swift-dependencies, but will very soon).

@stephencelis
Copy link
Member Author

@finestructure I haven't dug into it too deeply, but I think when Windows dynamic linking support was added it stopped working. If you are able to get things working, though, please let us know!

@finestructure
Copy link
Contributor

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants