Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyClient - Ignore @Dependency and @DependencyEndpointIgnored properties #212

Merged
merged 1 commit into from
May 6, 2024

Conversation

freak4pc
Copy link
Contributor

@freak4pc freak4pc commented May 6, 2024

As discussed on Slack, this PR adds two fixes:

  1. A new @DependencyEndpointIgnored macro which can be used to skip a specific property from code generation
  2. Automatically skip properties marked with @Dependency or @DependencyEndpointIgnored

I've added some tests and also tested it on my local use case which works well:

image

@freak4pc
Copy link
Contributor Author

freak4pc commented May 6, 2024

FYI @stephencelis

@freak4pc freak4pc force-pushed the dependency-macro-ignored branch from 91c8219 to 8edf6af Compare May 6, 2024 20:19
@freak4pc freak4pc force-pushed the dependency-macro-ignored branch from 8edf6af to 6645fb1 Compare May 6, 2024 20:20
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for tackling this 😄

@stephencelis stephencelis merged commit cf57a1c into pointfreeco:main May 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants