Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(page): add proper meta description #1171

Merged
merged 1 commit into from
Jan 1, 2025
+20 −21
Merged

chore(page): add proper meta description #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/page/src/features/PageHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="flex h-12 bg-primary-900 text-complementary-900 font-light justify-center items-center px-16 border-b border-complementary-300 top-0 w-full overflow-hidden transition-colors duration-300"
>
<nav class="flex w-app items-center justify-center">
<a :href="state.index" class="mr-4 font-semibold">
<a :href="state.index" class="mr-4 font-semibold truncate">
{{ state.title }}
</a>
<a class="mr-4 font-light" :href="state.index" :title="state.title">{{
Expand Down
2 changes: 1 addition & 1 deletion apps/page/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const lang = getLanguage();
</script>
<ClientRouter />
</head>
<body>
<body class="min-w-[380px]">
<Colors client:only="vue" />
<LoadingBar client:only="vue" />
<PageHeader client:idle transition:persist="header" />
Expand Down
4 changes: 2 additions & 2 deletions apps/page/src/pages/feed/[...feed]/episode/[episodeId].astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,13 @@ const timeline = [

/* Links */
.episode-content a {
color: rgba(var(--complementary-color-900), 0.5);
color: rgba(var(--primary-color-900));
text-decoration: none;
}

.episode-content a:focus,
.episode-content a:hover {
color: rgba(var(--complementary-color-900));
text-decoration: underline;
}

/* Image */
Expand Down
2 changes: 1 addition & 1 deletion apps/page/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const lang = getLanguage();
<html lang={lang}>
<head>
<meta charset="UTF-8" />
<meta name="description" content="Astro description" />
<meta name="description" content="Illuminate your RSS Feed" />
<meta name="viewport" content="width=device-width" />
<link rel="icon" type="image/svg+xml" href="icon.svg" />
<meta name="generator" content="Podlove Lux" />
Expand Down
31 changes: 15 additions & 16 deletions apps/page/src/screens/episodes/Navigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
</template>

<script setup lang="ts">
import { ref, type Ref } from 'vue'
import scrollIntoView from 'scroll-into-view-if-needed'
import { ref, type Ref } from 'vue';
import scrollIntoView from 'scroll-into-view-if-needed';
import { TimelineIcon, SummaryIcon, ShownotesIcon, DiscussIcon } from '@podlove/components';
import { onMounted } from 'vue';
import { throttle } from 'lodash-es';
Expand All @@ -71,32 +71,31 @@ defineProps<{
shownotes: boolean;
discuss: boolean;
timeline: boolean;
}>()
}>();
const navigation: Ref<HTMLElement | null> = ref(null);
const navigation: Ref<HTMLElement | null> = ref(null);
const docked = ref(false);
const handleScroll = () => {
const height = navigation.value?.clientHeight || 0
const top = navigation.value?.offsetTop || 0
const scroll = window.scrollY
docked.value = scroll > height + top + 100
}
const height = navigation.value?.clientHeight || 0;
const top = navigation.value?.offsetTop || 0;
const scroll = window.scrollY;
docked.value = scroll > height + top + 100;
};
const scrollTo = (id: string) => {
const node = document.getElementById(id)
node && scrollIntoView(node, { behavior: 'smooth', scrollMode: 'always', block: 'start' })
}
const node = document.getElementById(id);
node && scrollIntoView(node, { behavior: 'smooth', scrollMode: 'always', block: 'start' });
};
onMounted(() => {
handleScroll()
window && window.addEventListener('scroll', throttle(handleScroll, 100))
})
handleScroll();
window && window.addEventListener('scroll', throttle(handleScroll, 100));
});
</script>

<style scoped>
.docked {
transition: z-index 300ms;
}
Expand Down
Loading