Skip to content

Commit

Permalink
fix: player ci
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-heimbuch committed Nov 12, 2023
1 parent 818d844 commit 815fc21
Show file tree
Hide file tree
Showing 16 changed files with 535 additions and 44 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,15 @@ jobs:
- name: install
run: pnpm install --offline
- name: lint
run: npx eslint 'apps/player/**/*.{js,vue}'
run: pnpm lint --scope @podlove/player
- name: build
run: pnpm build --scope @podlove/player
- name: integration
uses: cypress-io/github-action@v5
with:
browser: chrome
build: npx lerna run integration:build --scope @podlove/player --stream
start: npx lerna run integration:server --scope @podlove/player --stream
start: pnpm start --scope @podlove/player --stream
project: ./apps/player
- name: build
run: npx lerna run build --scope @podlove/player --stream

apps_web-player:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
!.prettierignore
!.storybook
!.drone.yml
!.drone.yml
!.browserslistrc
!.eslintrc.json

coverage

Expand Down
25 changes: 25 additions & 0 deletions apps/player/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"env": {
"browser": true,
"es2021": true
},
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:vue/vue3-essential"
],
"parserOptions": {
"ecmaVersion": "latest",
"parser": "@typescript-eslint/parser",
"sourceType": "module"
},
"plugins": [
"@typescript-eslint",
"vue"
],
"rules": {
"@typescript-eslint/no-explicit-any": 0,
"@typescript-eslint/no-namespace": 0,
"vue/multi-word-component-names": 0
}
}
24 changes: 14 additions & 10 deletions apps/player/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"scripts": {
"serve": "vite serve",
"build": "vite build",
"postpublish": "npm run clean",
"integration:ci": "cypress run --browser chrome",
"integration:dev": "cypress open --browser chrome"
"integration:dev": "cypress open --browser chrome",
"lint": "eslint src/**/*.{vue,ts} cypress/**/*.ts"
},
"keywords": [],
"author": "Alexander Heimbuch <[email protected]>",
Expand All @@ -25,24 +25,28 @@
"@podlove/utils": "workspace:*",
"core-js": "3.15.2",
"date-fns": "2.16.1",
"farbraum": "0.1.4",
"ramda": "0.29.0",
"redux": "4.2.0",
"redux-vuex": "3.0.0",
"vue": "3.2.41",
"vue-i18n": "9.2.2",
"farbraum": "0.1.4",
"reselect": "4.1.8",
"tailwindcss": "3.2.4",
"reselect": "4.1.8"
"vue": "3.2.41",
"vue-i18n": "9.2.2"
},
"devDependencies": {
"@types/node": "20.8.4",
"@typescript-eslint/eslint-plugin": "^6.10.0",
"@typescript-eslint/parser": "^6.10.0",
"@vitejs/plugin-vue": "3.2.0",
"cypress": "13.1.0",
"cypress-vite": "1.4.2",
"vite": "4.3.5",
"vite-plugin-dynamic-publicpath": "1.1.2",
"eslint": "^8.53.0",
"eslint-plugin-vue": "^9.18.1",
"http-server": "14.1.1",
"typescript": "5.0.4",
"cypress": "13.1.0",
"@types/node": "20.8.4"
"vite": "4.3.5",
"vite-plugin-dynamic-publicpath": "1.1.2"
},
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion apps/player/src/components/error/Error.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
class="podlove-player--error--retry-button px-5 py-2 rounded-sm"
:style="{ ...state.headline }"
data-test="error--retry"
@click.native="retryAction"
@click="retryAction"
>
{{ t('PLAYER.RETRY') }}
</button>
Expand Down
13 changes: 5 additions & 8 deletions apps/player/src/components/publication-date/PublicationDate.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,13 @@

<script lang="ts" setup>
import { computed } from 'vue';
import { format } from 'date-fns';
import { format as dateFormat } from 'date-fns';
import { mapState } from 'redux-vuex';
import select from '../../store/selectors/index.js';
const props = defineProps({
format: {
type: String,
default: null
}
});
const props = defineProps<{
format: string;
}>();
const state = mapState({
publicationDate: select.episode.publicationDate
Expand All @@ -22,7 +19,7 @@ const state = mapState({
const date = computed(() => {
const date = new Date(state.publicationDate);
return props.format ? format(date, props.format) : date.toLocaleDateString();
return props.format ? dateFormat(date, props.format) : date.toLocaleDateString();
});
</script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<facebook-channel
:link="state.link"
:filled="hover"
@mouseover.native="mouseOver"
@mouseleave.native="mouseLeave"
@mouseover="mouseOver"
@mouseleave="mouseLeave"
/>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
:text="shareText"
:subject="shareSubject"
:filled="hover"
@mouseover.native="mouseOver"
@mouseleave.native="mouseLeave"
@mouseover="mouseOver"
@mouseleave="mouseLeave"
/>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
:color="state.color"
:background="state.background"
:filled="hover"
@mouseover.native="mouseOver"
@mouseleave.native="mouseLeave"
@mouseover="mouseOver"
@mouseleave="mouseLeave"
/>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
:text="shareText"
:link="state.link"
:filled="hover"
@mouseover.native="mouseOver"
@mouseleave.native="mouseLeave"
@mouseover="mouseOver"
@mouseleave="mouseLeave"
/>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<twitter-channel
:text="shareText"
:filled="hover"
@mouseover.native="mouseOver"
@mouseleave.native="mouseLeave"
@mouseover="mouseOver"
@mouseleave="mouseLeave"
/>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<whats-app-channel
:text="shareText"
:filled="hover"
@mouseover.native="mouseOver"
@mouseleave.native="mouseLeave"
@mouseover="mouseOver"
@mouseleave="mouseLeave"
/>
</template>

Expand Down
1 change: 0 additions & 1 deletion apps/player/src/components/tab-trigger/TabTrigger.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import { computed } from 'vue';
import { useI18n } from 'vue-i18n';
import { mapState, injectStore } from 'redux-vuex';
import { prop } from 'ramda';
import { ActiveTabIcon } from '@podlove/components';
import { toggleTab } from '@podlove/player-actions/tabs';
Expand Down
1 change: 1 addition & 0 deletions apps/player/src/store/state.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-unused-vars: 0 */
import { State as runtime } from '@podlove/player-state/runtime';
import { State as theme } from '@podlove/player-state/theme';
import { State as episode } from '@podlove/player-state/episode';
Expand Down
8 changes: 3 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,14 @@
"name": "root",
"private": true,
"scripts": {
"clean": "rm -rf apps/**/dist apps/**/publish packages/**/dist packages/**/publish",
"format": "eslint --fix '**/*.{js,jsx,vue}'",
"lint": "eslint -f codeframe '**/*.{js,jsx,vue}'",
"start": "lerna run dev --scope @podlove/docs --stream",
"lint": "lerna run lint",
"test": "lerna run test",
"test:dev": "lerna run test:dev",
"build": "lerna run build",
"integration:dev": "lerna run integration:dev",
"update": "lernaupdate",
"version": "lerna version --conventional-commits --changelog-preset angular",
"start": "lerna run dev --scope @podlove/docs --stream"
"version": "lerna version --conventional-commits --changelog-preset angular"
},
"devDependencies": {
"cz-conventional-changelog": "3.3.0",
Expand Down
Loading

0 comments on commit 815fc21

Please sign in to comment.