Eliminate the last --define from test-suite run() function

The snapshot case always needs a wrapper function of some kind,
so it makes sense to optimize the setup for the non-snapshot case to
allow running commands without any wrappers in the way.

Set the test-suite %_tmppath as per non-snapshot case and move the
last remaining command line --define override to runroot() instead.
This makes run() entirely redundant.

The %_tmppath override in runroot() shouldn't really be necessary but
scriptlet related tests fail without that. I suspect it's related to
/tmp being tmpfs in the test-suite but dunno. It's a mystery for some
other day...

tests/atlocal.in

@@ -112,8 +112,7 @@ setup_env()
 
 run()
 {
-    "$@" \
-         --define "_tmppath ${RPMTEST}/tmp"
+    "$@"
 }
 
 rundebug()
@@ -127,7 +126,8 @@ rundebug()
 
 runroot()
 {
-    snapshot exec "$@"
+    snapshot exec "$@" \
+             --define "_tmppath /var/tmp"
 }
 
 runroot_other()

tests/data/macros.testenv

@@ -1,3 +1,4 @@
 # root's macro config in the test-environment
 %_buildhost testhost
 %_topdir %{getenv:RPMTEST}/build
+%_tmppath %{getenv:RPMTEST}/tmp