chore: clean up

[0xmad]

• Add checks for ci actions
• Run prettier, clippy, fmt commands for all the files
• Move circom circuits to a circom folder
• Get rid of js var statements
• Speed up circom tests by moving them to separate files and run concurrently

[Divide-By-0]

This looks great! Until @skaunov reviews it, do you want to send your wallet address and I can send a bounty?

[0xmad]

@Divide-By-0 sorry, but I work at PSE :)

[Divide-By-0]

@Divide-By-0 sorry, but I work at PSE :)

Oh you know what, that makes a lot of sense LOL

[skaunov]

I stumbled through, looking into what caught my attention. GA upgrades are very cool, lots of useful settings/setups, and so on.
The one thing that I would highlight is replacing Yarn for pnpm. I don't follow JS really closely, and my knowledge of it is pretty basic; I mean no defense of Yarn from my side, heh. The sole reason I highlight the fact is that with mine casual exposure to JS I never came across pnpm AFAIR. On the other hand I guess @0xmad wouldn't put it here if it weren't developer friendly.

That's all from me, other added comments are truly minor.

[0xmad]

@skaunov thanks for the review. I added pnpm just because it's faster and it's easier to use it as monorepo tool (I'll add workspaces later to get rid of relative paths inside circuits/circom).

[skaunov]

All items which caught my attention was addressed; so I have nothing to add to the previous review!

[skaunov]

I just noticed that @Divide-By-0 asked actually to also merge this one. %)

[skaunov]

Just noticed that we have path with repetition now: <circuits/circom/test/circuits>. I personally try to avoid this due to minor discomfort it brings, so want to attract your attention to this. Though if everybody fine with it, then...

[0xmad]

@skaunov what's the problem with it? It's not going to be exported and it uses internally inside test folder.

[skaunov]

Path at

zk-nullifier-sig/README.md

Line 44 in 79c6026

Then, navigate to the `circuits/` directory and install the dependencies there:

should also corrected, right? @0xmad

[skaunov]

I also received when was quickly running the instructions.

devbox@pop-os:~/zk-nullifier-sig/circuits/circom$ pnpm run flatten-deps && pnpm run test
 ERR_PNPM_NO_SCRIPT  Missing script: flatten-deps

Command "flatten-deps" not found.

[0xmad]

circuits/ path yes, should be corrected.
You don't need to run flatten-deps with test. It's automatically run after pnpm install.