more phpstan

pluginsGLPI · Nov 10, 2023 · 718303f · 718303f
1 parent eac70da
commit 718303f
Show file tree

Hide file tree

Showing 11 changed files with 34 additions and 15 deletions.
diff --git a/ajax/dropdownQuantity.php b/ajax/dropdownQuantity.php
@@ -35,7 +35,7 @@
 
 Session::checkLoginUser();
 
-/** @var DBmysql */
+/** @var DBmysql $DB */
 global $DB;
 
 if (isset($_POST["entity"])) {

diff --git a/hook.php b/hook.php
@@ -111,7 +111,7 @@ function plugin_credit_getDropdown()
 
 function plugin_credit_get_datas(NotificationTargetTicket $target)
 {
-
+    /** @var DBmysql $DB */
     global $DB;
 
     $target->data['##lang.credit.voucher##'] = PluginCreditEntity::getTypeName();

diff --git a/inc/entity.class.php b/inc/entity.class.php
@@ -42,7 +42,7 @@ public static function getTypeName($nb = 0)
         return _n('Credit voucher', 'Credit vouchers', $nb, 'credit');
     }
 
-    public function getTabNameForItem(CommonGLPI $item, $withtemplate = false)
+    public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
         $nb = self::countForItem($item);
         switch ($item->getType()) {
@@ -57,7 +57,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = false)
         return '';
     }
 
-    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = false)
+    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
     {
         switch ($item->getType()) {
             case 'Entity':
@@ -123,6 +123,7 @@ public function post_purgeItem()
     */
     public static function getAllForEntity($ID, $sqlfilter = []): array
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $request = [
@@ -443,6 +444,10 @@ public static function cronInfo($name)
 
     public static function cronCreditExpired($task)
     {
+        /**
+         * @var array $CFG_GLPI
+         * @var DBmysql $DB
+         */
         global $CFG_GLPI, $DB;
 
         if (!$CFG_GLPI['use_notifications']) {
@@ -521,6 +526,7 @@ public static function cronCreditExpired($task)
     */
     public static function install(Migration $migration)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $default_charset = DBConnection::getDefaultCharset();
@@ -582,6 +588,7 @@ public static function uninstall(Migration $migration)
 
     public static function getActiveFilter()
     {
+        /** @var DBmysql $DB */
         global $DB;
         return [
             'glpi_plugin_credit_entities.is_active' => 1,

diff --git a/inc/entityconfig.class.php b/inc/entityconfig.class.php
@@ -178,6 +178,7 @@ public static function getDefaultForEntityAndType($entity_id, $itemtype)
 
     public static function install(Migration $migration)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $default_charset = DBConnection::getDefaultCharset();

diff --git a/inc/notificationtargetentity.class.php b/inc/notificationtargetentity.class.php
@@ -40,6 +40,7 @@ public function getEvents()
 
     public function addDataForTemplate($event, $options = [])
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $this->data['##credit.name##'] = $this->obj->getField('name');
@@ -116,6 +117,7 @@ public function getTags()
 
     public static function install(Migration $migration)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $template     = new NotificationTemplate();
@@ -209,6 +211,7 @@ public static function install(Migration $migration)
 
     public static function uninstall()
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $notification = new Notification();

diff --git a/inc/profile.class.php b/inc/profile.class.php
@@ -31,12 +31,12 @@
 
 class PluginCreditProfile extends Profile
 {
-    public function getTabNameForItem(CommonGLPI $item, $withtemplate = false)
+    public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
         return self::createTabEntry(PluginCreditTicket::getTypeName(Session::getPluralNumber()));
     }
 
-    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = false)
+    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
     {
         $profile = new self();
         /** @phpstan-ignore-next-line  */

diff --git a/inc/ticket.class.php b/inc/ticket.class.php
@@ -42,7 +42,7 @@ public static function getTypeName($nb = 0)
         return _n('Credit voucher', 'Credit vouchers', $nb, 'credit');
     }
 
-    public function getTabNameForItem(CommonGLPI $item, $withtemplate = false)
+    public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
         $nb = self::countForItem($item);
         switch ($item->getType()) {
@@ -58,7 +58,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = false)
         return '';
     }
 
-    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = false)
+    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
     {
         switch ($item->getType()) {
             case 'Ticket':
@@ -84,6 +84,7 @@ public static function countForItem(CommonDBTM $item)
     */
     public static function getAllForTicket($ID): array
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $request = [
@@ -112,6 +113,7 @@ public static function getAllForTicket($ID): array
    **/
     public static function getAllForCreditEntity($ID): array
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $request = [
@@ -138,6 +140,7 @@ public static function getAllForCreditEntity($ID): array
    **/
     public static function getConsumedForCreditEntity($ID)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $tot   = 0;
@@ -166,7 +169,8 @@ public static function getConsumedForCreditEntity($ID)
    **/
     public static function showForTicket(Ticket $ticket)
     {
-        global $DB, $CFG_GLPI;
+        /** @var DBmysql $DB */
+        global $DB;
 
         $ID = $ticket->getField('id');
         if (!$ticket->can($ID, READ)) {
@@ -347,8 +351,6 @@ public static function showForTicket(Ticket $ticket)
     public static function displayVoucherInTicketProcessingForm($params)
     {
 
-        global $CFG_GLPI;
-
         $item = $params['item'];
 
         if ($item instanceof Ticket) {
@@ -706,6 +708,7 @@ public function rawSearchOptions()
     */
     public static function install(Migration $migration)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $default_charset = DBConnection::getDefaultCharset();

diff --git a/inc/ticketconfig.class.php b/inc/ticketconfig.class.php
@@ -290,6 +290,7 @@ public static function updateConfig(Ticket $ticket)
 
     public static function install(Migration $migration)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $table = self::getTable();

diff --git a/inc/type.class.php b/inc/type.class.php
@@ -51,6 +51,7 @@ public static function getTypeName($nb = 0)
     */
     public static function install(Migration $migration)
     {
+        /** @var DBmysql $DB */
         global $DB;
 
         $default_charset = DBConnection::getDefaultCharset();

diff --git a/phpstan.neon b/phpstan.neon
@@ -4,14 +4,16 @@ parameters:
     level: 2
     bootstrapFiles:
         - ../../inc/based_config.php
-        - setup.php
     paths:
-        - inc
-        - front
         - ajax
+        - front
+        - inc
         - hook.php
+        - setup.php
     scanDirectories:
         - ../../inc
         - ../../src
     stubFiles:
         - ../../stubs/glpi_constants.php
+rules:
+    - GlpiProject\Tools\PHPStan\Rules\GlobalVarTypeRule
diff --git a/setup.php b/setup.php
@@ -44,7 +44,8 @@
  */
 function plugin_init_credit()
 {
-    global $PLUGIN_HOOKS, $CFG_GLPI;
+    /** @var array $PLUGIN_HOOKS */
+    global $PLUGIN_HOOKS;
 
     $plugin = new Plugin();