Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove recursive config sanitisation #113

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix: Remove recursive config sanitisation #113

merged 1 commit into from
Oct 21, 2023

Conversation

boazpoolman
Copy link
Member

@boazpoolman boazpoolman commented Oct 20, 2023 •
edited
Loading

What does it do?

As of #93 all configuration files would be sanitized recursively.
That resulted in some unwanted behaviour (see #110) and turned out to be unnecessary.

This PR removes that recursive sanitisation.

Why is it needed?

To solve #110

How to test it?

  1. Replicate The screen does not update when we import settings #110
  2. Update the plugin to make use of this PR:
yarn add boazpoolman/strapi-plugin-config-sync#pull/113/head
  1. See the issue being fixed.

@boazpoolman boazpoolman mentioned this pull request Oct 20, 2023
Closed
@MSACC MSACC merged commit 88a40e7 into master Oct 21, 2023
4 checks passed
@MSACC MSACC deleted the feature/fix-config-sanitization-utility branch October 21, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSACC MSACC MSACC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boazpoolman @MSACC