Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dev-dependencies and CI environment #570

Merged
merged 4 commits into from
Mar 7, 2024
Merged

update dev-dependencies and CI environment #570

merged 4 commits into from
Mar 7, 2024

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Mar 6, 2024 •
edited
Loading

  • use Node 20 and PHP 8.2 for quality tests
  • update dev-dependencies
    • yes, much of the behat stuff is still very old, including PHPUnit 4 - just the low hanging fruits for now
  • minor code style weaks for WPCS 3
    • replace echo sprintf() with printf()
    • some whitespaces and line breaks
  • add PHP 8.3 to build matrix

supersedes #566 and #569

@stklcode stklcode changed the title ci: build with Node 20 and PHP 8.2 update dev-dependencies and CI environment Mar 6, 2024
@stklcode stklcode added the dependencies Pull requests that update a dependency file label Mar 6, 2024
@stklcode stklcode force-pushed the update-devenv branch 3 times, most recently from d557b15 to 9b86bc8 Compare March 6, 2024 16:10
@stklcode stklcode marked this pull request as ready for review March 6, 2024 16:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Zodiac1978
Zodiac1978 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stklcode stklcode self-assigned this Mar 7, 2024
@stklcode stklcode merged commit 66bc912 into master Mar 7, 2024
11 checks passed
@stklcode stklcode deleted the update-devenv branch March 7, 2024 18:58
@stklcode stklcode mentioned this pull request Mar 7, 2024
Closed
@stklcode stklcode added this to the 2.11.6 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zodiac1978 Zodiac1978 Zodiac1978 approved these changes

@florianbrinkmann florianbrinkmann Awaiting requested review from florianbrinkmann

Assignees

@stklcode stklcode

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.11.6
Development

Successfully merging this pull request may close these issues.
2 participants
@stklcode @Zodiac1978