fix error on clearing crosstalk selection #2098
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking plots using {crosstalk}, running
selectionHandle.clear()
from another (non-plotly) visual causes the following error to appear in the console and the selection in the plotly visual is not cleared:This is because
selectionHandle.clear()
event passes anundefined
value, which plotly isn't dealing with properly.This PR fixes this issue.