feat: corrected region names in table #4334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed regions.html file and regions.md file
Why
Closes #4331
What's changed
So I had to correct the region names in the table on this page. I also had to correct the region names in the list below the
Where REGION is one of the impacted regions
section.The region names were displayed as
us-3.upsun.com
for example, when they should beus-3.platform.sh
regardless of whether it's on Upsun or Platform.sh.Where are changes
I went into the
regions.md
file and replaced the shortcode with text so regions would change from ch-1.upsun.com to ch-1.platform.sh.I also went into the
regions.html
file and changed thecode class="!bg-snow">
. In particular, I removed the code that was pulling in the site url automatically and just replaced that with text that said "platform.sh". It seemed like the easiest way to ensure it's hard coded and consistent across Upsun and Platform.sh.I didn't change the Inbound IPs column in the table as that seemed correct. It points to an url ending
platformsh.site
. Can I confirm that's correct please?Updates are for:
sites/platform
templates)sites/upsun
templates)