Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: corrected region names in table #4334

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

Kemi-Elizabeth
Copy link
Collaborator

Changed regions.html file and regions.md file

Why

Closes #4331

What's changed

So I had to correct the region names in the table on this page. I also had to correct the region names in the list below the Where REGION is one of the impacted regions section.

The region names were displayed as us-3.upsun.com for example, when they should be us-3.platform.sh regardless of whether it's on Upsun or Platform.sh.

Where are changes

I went into the regions.md file and replaced the shortcode with text so regions would change from ch-1.upsun.com to ch-1.platform.sh.

I also went into the regions.html file and changed the code class="!bg-snow">. In particular, I removed the code that was pulling in the site url automatically and just replaced that with text that said "platform.sh". It seemed like the easiest way to ensure it's hard coded and consistent across Upsun and Platform.sh.

I didn't change the Inbound IPs column in the table as that seemed correct. It points to an url ending platformsh.site. Can I confirm that's correct please?

Updates are for:

  • platform (sites/platform templates)
  • upsun (sites/upsun templates)

Changed regions.html file and regions.md file
@Kemi-Elizabeth Kemi-Elizabeth self-assigned this Jan 9, 2025
@Kemi-Elizabeth Kemi-Elizabeth linked an issue Jan 9, 2025 that may be closed by this pull request
@Kemi-Elizabeth Kemi-Elizabeth requested review from gilzow and chadwcarlson and removed request for gilzow January 9, 2025 15:22
@gilzow
Copy link
Collaborator

gilzow commented Jan 9, 2025

This "situation" is a remnant of when the two docs were intertwined, and missed when they were separated. Since we're planning on restructuring docs anyway, I think hard-coding the platform.sh parts is perfectly acceptable.

@gilzow gilzow merged commit 0714ef6 into main Jan 9, 2025
16 checks passed
@gilzow gilzow deleted the 4331-correct-region-names branch January 9, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct region names
3 participants