Add Share button for blobs #1074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_audio_video_blobs_2
|
I'm closing this PR for now as it isn't one of our top priorities at the moment. We can reopen it if we prioritize it again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very WIP. The original goal was to display video blobs (#716), so I was rewriting a lot of our Blob-related code to not assume everything is an image. But I had problems getting the video controls to render, so I pivoted to just having a share button for all blobs (#1138). This was done before we rewrote the Discover screen in SwiftUI.
Left to do:
main. There will probably be some merge conflicts here because I was trying to update some UIKit views which we are no longer using onmainI think.