WIP : Introduce ISystemAccounts

[OnedgeLee]

Background

• Predefined System Accounts are needed.
• For better structure, they have to be found from IActionContext.
• Some of them (ex : fee account) have to be defined on application.
  • For future, especially for PoS, needs to specify accounts for PoS is needed, and since they're related to FAVs, that specification may be happen on application.

Note

• Predefined account address LegacyAccount has been renamed to DefaultAccount, to cover single account application case. What I'm thinking is,
  • Provide both of initialization action : single-account initialization and multi-account initialization.
  • Provide migration path of single-to-multi account initialization
  • With this scheme, word Legacy seems to be better to be called Default I think.
  • When use word Legacy, seems to be legacy one is deprecated, or obsoleted, but I think it's better to provide both.

Changes

• Introduce ISystemAccounts
• Add IActionContext.SystemAccounts
• Introduce ISystemAccountsGetter
• Add IBlockPolicy.SystemAccountsGetter
• Remove WorldExtensions, and replace them with SystemAccounts
• Migrate ValidatorSet from DefaultAccount to ValidatorSetAccount
  • Since ValidatorSetOperate is on application layer, most of work have to be done on app
  • Block improper access
  • Fix IBlockChainState, Explorer API
• Replace ReservedAddress.Addresses to Context.SystemAccounts on tests
• Make System Accounts cannot be set from outside of Libplanet? (ex : IAction.Execute() on app) -> a bit confused, does fee account needs to be mint from app actions?

[pull-request-quantifier-deprecated]

This PR has 894 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Large
Size       : +566 -328
Percentile : 96.47%

Total files changed: 72

Change summary by file extension:
.md : +6 -0
.cs : +560 -328

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[OnedgeLee]

Will be handled on #3494, Closing