refactor: apply suggestions from the review

planetarium · Dec 12, 2024 · c1a205d · c1a205d
1 parent 1f4e1c9
commit c1a205d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 22 deletions.
diff --git a/src/Libplanet.Net/Consensus/Context.Mutate.cs b/src/Libplanet.Net/Consensus/Context.Mutate.cs
@@ -29,7 +29,7 @@ private void StartRound(int round)
             RoundStarted?.Invoke(this, Round);
             _heightVoteSet.SetRound(round);
 
-            SetProposal(null);
+            Proposal = null;
             Step = ConsensusStep.Propose;
             if (_validatorSet.GetProposer(Height, Round).PublicKey == _privateKey.PublicKey)
             {
@@ -214,7 +214,7 @@ private void AddProposal(Proposal proposal)
 
             if (Proposal is null)
             {
-                SetProposal(proposal);
+                Proposal = proposal;
                 _logger.Debug("Proposal {BlockHash} is set", proposal.BlockHash);
             }
             else
@@ -341,7 +341,7 @@ private void ProcessGenericUponRules()
                         Round,
                         hash3,
                         ToString());
-                    SetProposal(null);
+                    Proposal = null;
                     PublishMessage(
                         new ConsensusProposalClaimMsg(
                             new ProposalClaimMetadata(

diff --git a/src/Libplanet.Net/Consensus/Context.cs b/src/Libplanet.Net/Consensus/Context.cs
@@ -100,6 +100,7 @@ private readonly EvidenceExceptionCollector _evidenceCollector
         private readonly ILogger _logger;
         private readonly LRUCache<BlockHash, bool> _blockValidationCache;
 
+        private Proposal? _proposal;
         private Block? _proposalBlock;
         private Block? _lockedValue;
         private int _lockedRound;
@@ -219,7 +220,24 @@ private Context(
         /// </summary>
         public ConsensusStep Step { get; private set; }
 
-        public Proposal? Proposal { get; private set; }
+        public Proposal? Proposal
+        {
+            get => _proposal;
+            private set
+            {
+                if (value is { } p)
+                {
+                    _proposal = p;
+                    _proposalBlock =
+                        BlockMarshaler.UnmarshalBlock((Dictionary)_codec.Decode(p.MarshaledBlock));
+                }
+                else
+                {
+                    _proposal = null;
+                    _proposalBlock = null;
+                }
+            }
+        }
 
         /// <inheritdoc cref="IDisposable.Dispose()"/>
         public void Dispose()
@@ -589,24 +607,6 @@ private Maj23 MakeMaj23(int round, BlockHash hash, VoteFlag flag)
                 flag).Sign(_privateKey);
         }
 
-        /// <summary>
-        /// Sets the proposal for the round.
-        /// </summary>
-        private void SetProposal(Proposal? proposal)
-        {
-            if (proposal is { } p)
-            {
-                Proposal = proposal;
-                _proposalBlock =
-                    BlockMarshaler.UnmarshalBlock((Dictionary)_codec.Decode(p.MarshaledBlock));
-            }
-            else
-            {
-                Proposal = null;
-                _proposalBlock = null;
-            }
-        }
-
         /// <summary>
         /// Gets the proposed block and valid round of the given round.
         /// </summary>