pkp/pkp-lib#9661 Allow Journal Managers to invite users to adopt a role - ORCiD #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewhanson
force-pushed
the
i9661
branch
2 times, most recently
from
6f460ad to
91931b8
Compare
bozana
reviewed
Jan 14, 2025
| @@ -311,7 +398,12 @@ export const useAcceptInvitationPageStore = defineComponentStore( | |||
| method: 'PUT', | |||
| body: {invitationData: invitationRequestPayload.value}, | |||
| }); | |||
| if (!acceptInvitationPayload.value.privacyStatement) { | |||
| // FIXME: Privacy statement check blocks ORCID from saving before hand. | |||
| // Can this check be moved outside of update payload check? | |||
There was a problem hiding this comment.
Who could best help with this question?
There was a problem hiding this comment.
Probably @jardakotesovec, but I know he's quite busy. If he and you think it's okay, we could merge this as-is, and I could tackle this as a separate issue to keep things moving. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.