Do not add streams after association is closed #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 81.20% 81.22% +0.01%
==========================================
Files 51 51
Lines 3336 3339 +3
==========================================
+ Hits 2709 2712 +3
Misses 481 481
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Aug 12, 2024
association.go
Outdated
Comment on lines
1509
to
1512
| if a.getState() == closed { | ||
| return nil, ErrAssociationClosed | ||
| } |
There was a problem hiding this comment.
Do we need to include the shutdown states here?
shutdownAckSent
shutdownPending
shutdownReceived
shutdownSent
There was a problem hiding this comment.
I don't strictly think so but it can't hurt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, there's a race between OpenStream and the readLoop unregistering streams. When the race happens, a stream is leaked and will get stuck in a read loop waiting forever.