-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC refactoring #306
Draft
mengelbart
wants to merge
7
commits into
master
Choose a base branch
from
gcc-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
GCC refactoring #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all NTP related functions to the NTP package and adds a function to recover a time.Time from a uint32 encoded NTP timestamp.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
+ Coverage 71.31% 71.79% +0.48%
==========================================
Files 80 97 +17
Lines 4483 5279 +796
==========================================
+ Hits 3197 3790 +593
- Misses 1153 1341 +188
- Partials 133 148 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengelbart
force-pushed
the
gcc-refactoring
branch
from
January 20, 2025 19:18
13faffe
to
189d1ca
Compare
mengelbart
force-pushed
the
gcc-refactoring
branch
11 times, most recently
from
January 23, 2025 15:02
7c75813
to
136961c
Compare
mengelbart
force-pushed
the
gcc-refactoring
branch
from
January 23, 2025 15:02
136961c
to
a84ca53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the GCC implementation using the new API introduced in #300. Currently, users are responsible for creating a
SendSideController
, reading CCFB reports from the attributes, and passing them to theSendSideController
. This does not include pacing, which needs to be handled separately. Since the new controller does not need to read or pace outgoing packets, we no longer need the cumbersome callback API to get a pointer to the bandwidth estimator.This refactoring also cleans up the architecture of the bandwidth estimator. It no longer uses the weird pipelining structure and no longer uses any concurrency. This should also fix/close some of the open issues and PRs like #271, #299, #260, #221, #296.
This should not be merged before #300 is merged. A follow-up PR to this one will clean up the old
pkg/gcc
directory to use this version.