Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC refactoring #306

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

GCC refactoring #306

wants to merge 7 commits into from

Conversation

mengelbart
Copy link
Contributor

Description

This PR refactors the GCC implementation using the new API introduced in #300. Currently, users are responsible for creating a SendSideController, reading CCFB reports from the attributes, and passing them to the SendSideController. This does not include pacing, which needs to be handled separately. Since the new controller does not need to read or pace outgoing packets, we no longer need the cumbersome callback API to get a pointer to the bandwidth estimator.

This refactoring also cleans up the architecture of the bandwidth estimator. It no longer uses the weird pipelining structure and no longer uses any concurrency. This should also fix/close some of the open issues and PRs like #271, #299, #260, #221, #296.

This should not be merged before #300 is merged. A follow-up PR to this one will clean up the old pkg/gcc directory to use this version.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 74.93261% with 186 lines in your changes missing coverage. Please review.

Project coverage is 71.79%. Comparing base (e187410) to head (a84ca53).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/bwe/send_side_bwe.go 0.00% 53 Missing ⚠️
pkg/bwe/delay_rate_controller.go 0.00% 37 Missing ⚠️
pkg/ccfb/interceptor.go 75.80% 24 Missing and 6 partials ⚠️
pkg/ccfb/twcc_receiver.go 72.72% 21 Missing ⚠️
pkg/bwe/state.go 70.27% 11 Missing ⚠️
pkg/bwe/usage.go 0.00% 10 Missing ⚠️
pkg/bwe/kalman.go 83.33% 8 Missing and 1 partial ⚠️
pkg/bwe/rate_controller.go 83.33% 8 Missing ⚠️
pkg/bwe/arrival_group_accumulator.go 84.61% 3 Missing and 1 partial ⚠️
pkg/bwe/acknowledgment.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   71.31%   71.79%   +0.48%     
==========================================
  Files          80       97      +17     
  Lines        4483     5279     +796     
==========================================
+ Hits         3197     3790     +593     
- Misses       1153     1341     +188     
- Partials      133      148      +15     
Flag Coverage Δ
go 71.68% <74.93%> (+0.50%) ⬆️
wasm 70.22% <74.79%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengelbart mengelbart force-pushed the gcc-refactoring branch 11 times, most recently from 7c75813 to 136961c Compare January 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant