Internal: Upgrade React to 18.3.1 (#3935)

Co-authored-by: pmaciaslanda <[email protected]>
pinterest · Jan 13, 2025 · eeef0cf · eeef0cf
1 parent 456d8f3
commit eeef0cf
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 15 deletions.
diff --git a/packages/gestalt-charts/package.json b/packages/gestalt-charts/package.json
@@ -17,8 +17,8 @@
   },
   "peerDependencies": {
     "gestalt": ">0.0.0",
-    "react": "^18.0",
-    "react-dom": "^18.0"
+    "react": "^18.3.1",
+    "react-dom": "^18.3.1"
   },
   "scripts": {
     "build": "rollup -c rollup.config.js",

diff --git a/packages/gestalt-datepicker/package.json b/packages/gestalt-datepicker/package.json
@@ -24,8 +24,8 @@
   },
   "peerDependencies": {
     "gestalt": ">0.0.0",
-    "react": "^18.0",
-    "react-dom": "^18.0"
+    "react": "^18.3.1",
+    "react-dom": "^18.3.1"
   },
   "scripts": {
     "build": "rollup -c rollup.config.js",

diff --git a/packages/gestalt/package.json b/packages/gestalt/package.json
@@ -19,8 +19,8 @@
     "gestalt-design-tokens": ">0.0.0"
   },
   "peerDependencies": {
-    "react": "^18.0",
-    "react-dom": "^18.0"
+    "react": "^18.3.1",
+    "react-dom": "^18.3.1"
   },
   "scripts": {
     "build": "rollup -c rollup.config.js",

diff --git a/packages/gestalt/src/Layer.tsx b/packages/gestalt/src/Layer.tsx
@@ -84,7 +84,6 @@ export default function Layer({
   }
 
   // After useEffect, we render the children into the portal container node outside the DOM hierarchy
-  // @ts-expect-error - TS2322 - Type 'ReactPortal' is not assignable to type 'ReactNode'.
   return createPortal(children, portalContainer.current);
 }
 

diff --git a/yarn.lock b/yarn.lock
@@ -5677,11 +5677,9 @@
     "@types/react" "*"
 
 "@types/react-dom@^18.1.0":
-  version "18.3.0"
-  resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.3.0.tgz#0cbc818755d87066ab6ca74fbedb2547d74a82b0"
-  integrity sha512-EhwApuTmMBmXuFOikhQLIBUn6uFg81SwLMOAUgodJF14SOBOCMdU04gDoYi0WOJJHD144TL32z4yDqCW3dnkQg==
-  dependencies:
-    "@types/react" "*"
+  version "18.3.5"
+  resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.3.5.tgz#45f9f87398c5dcea085b715c58ddcf1faf65f716"
+  integrity sha512-P4t6saawp+b/dFrUr2cvkVsfvPguwsxtH6dNIYRllMsefqFzkZk5UIjzyDOv5g1dXIPdG4Sp1yCR4Z6RCUsG/Q==
 
 "@types/react-is@^16.7.1 || ^17.0.0":
   version "17.0.3"
@@ -5729,9 +5727,9 @@
     csstype "^3.0.2"
 
 "@types/react@^18.1.0":
-  version "18.3.2"
-  resolved "https://registry.yarnpkg.com/@types/react/-/react-18.3.2.tgz#462ae4904973bc212fa910424d901e3d137dbfcd"
-  integrity sha512-Btgg89dAnqD4vV7R3hlwOxgqobUQKgx3MmrQRi0yYbs/P0ym8XozIAlkqVilPqHQwXs4e9Tf63rrCgl58BcO4w==
+  version "18.3.18"
+  resolved "https://registry.yarnpkg.com/@types/react/-/react-18.3.18.tgz#9b382c4cd32e13e463f97df07c2ee3bbcd26904b"
+  integrity sha512-t4yC+vtgnkYjNSKlFx1jkAhH8LgTo2N/7Qvi83kdEaUtMDiwpbLAktKDaAMlRcJ5eSxZkH74eEGt1ky31d7kfQ==
   dependencies:
     "@types/prop-types" "*"
     csstype "^3.0.2"
-Original file line number
+Diff line change
@@ Expand Up / @@ -84,7 +84,6 @@ export default function Layer({ @@
       }
       // After useEffect, we render the children into the portal container node outside the DOM hierarchy
-      // @ts-expect-error - TS2322 - Type 'ReactPortal' is not assignable to type 'ReactNode'.
       return createPortal(children, portalContainer.current);
     }
@@ Expand Down @@