Replace File::copy with SQLite .backup for Transactionally Safe Backups #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muco-rolle
changed the title
CamKem
requested changes
Dec 20, 2024
package.json
Outdated
Comment on lines
21
to
22
| } | ||
| }, | ||
| "packageManager": "[email protected]+sha512.76e2379760a4328ec4415815bcd6628dee727af3779aaa4c914e3944156c4299921a89f976381ee107d41f12cfa4b66681ca9c718f0668fa0831ed4c6d8ba56c" |
There was a problem hiding this comment.
Is this committed in error?
There was a problem hiding this comment.
Yes, this was committed by mistake. I have removed it now.
rector.php
Outdated
Comment on lines
10
to
14
| __DIR__.'/app', | ||
| __DIR__.'/bootstrap/app.php', | ||
| __DIR__.'/config', | ||
| __DIR__.'/database', | ||
| __DIR__.'/public', | ||
| __DIR__ . '/app', | ||
| __DIR__ . '/bootstrap/app.php', | ||
| __DIR__ . '/config', | ||
| __DIR__ . '/database', | ||
| __DIR__ . '/public', |
There was a problem hiding this comment.
Keep changes relevant to the focus of the PR.
There was a problem hiding this comment.
Yeah, I think this was added by my editor's formatter. Let me know if it's fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the article from Litestream, which advises against using the
cpcommand for SQLite database backups and recommends the.backupcommand or theVACUUM INTOstatement.This PR removes the
File::copymethod and replaces it with.backupfor a safer and transactionally consistent backup process.