-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Assistant code to RC branch #322
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
45c026b
Add latest code gen for 2025-01 RC
aulorbe cd48708
Incorporate newest code from stable
aulorbe a792a02
Update RC branch to include control plane for Assistants
aulorbe 84b04c3
Save work
aulorbe e75dcb7
Save work
aulorbe 37952ad
Got chat working!
aulorbe 4a31806
Add newly-generated code for Assistant data, control, and eval planes…
aulorbe 8c7dc4d
Match w/RC branch minus Assistant content
aulorbe ea135f7
update server paths
aulorbe 20dcf53
Got list to work
aulorbe 3d3e2c3
listFiles working
aulorbe 13976b9
Keeping uploadFile as blob for user + got deleteFile working
aulorbe 07902a2
Got Eval working
aulorbe 887fd91
Upload file workaround
aulorbe 813e5af
Got uploadFile with metadata to work!
aulorbe 8430b47
Add chatCompletions and contextAssistant
aulorbe a509fb5
Reset hash of submodule
aulorbe eed47de
Add newest gen. code
aulorbe 4a3bf40
Add Assistant singleton to deal with data plane regions
aulorbe 6cd624d
Rename file
aulorbe 690f279
Change from private to readonly to connote immutable intent of property
aulorbe e0e84ca
Start adding tests
aulorbe a5173b9
Finish unit tests
aulorbe 9a91af8
Add interface exports to top-level index.ts file
aulorbe d0089e3
Add createAssistant int. tests
aulorbe e3c4ac7
Add updateAssistant int. tests + new interface for better UX
aulorbe 4e9603a
Add delete int. tests + revise update int. tests
aulorbe 67a642e
Clean up + add listAssistants int. tests
aulorbe 0d578d4
Add getAssistant int. tests
aulorbe 896ff6e
Save work: centralization of assistant creation for int. tests + chat…
aulorbe b8fe94e
Remove text files
aulorbe 2dceee9
Add TEST_FILE env var to workflow files
aulorbe 462d559
Chat int. tests
aulorbe 187cb63
Add context and upload int. tests
aulorbe a5bcc7b
Add describeFile int. test beginnings
aulorbe 4327128
Add eval reorg + tests
aulorbe 1c5615a
Document control plane ops
aulorbe c6a1554
Cleanup
aulorbe 769a5dc
Add tests
aulorbe f989ce1
Documentation finished
aulorbe 2e1e63b
Up sleep to avoid flakiness
aulorbe a297ad4
Remove unnecessarily old version of TS + add newer versions
aulorbe bcb7a33
Update severe vulnerability in package
aulorbe 60af784
Clean up
aulorbe 9e7b454
Increase sleep, remove unnecessary export
aulorbe 0465545
Update docstrings, write README
aulorbe 187c4d3
Add more sleep so that file is available for describing
aulorbe 435229a
Merge branch 'release-candidate/2025-01' into add-assistant
aulorbe 2462a5f
refactor to move assistant control plane stuff into the Pinecone clas…
austin-denoble 2acac44
fix AssistantHostSingleton unit tests and issue accessing field
austin-denoble 4c343de
clean up docstrings, README, etc
austin-denoble e0367fb
fix Assistant import
austin-denoble 2bb6384
fix other import
austin-denoble ff40551
rework uploadFile to use basic node rest() along with generated inter…
austin-denoble fcaa739
clean up older uploadFile function, clean up action naming for assist…
austin-denoble ad21dee
add a step to make sure the next app is up and running before testing…
austin-denoble b0e0dd3
rework testing script a bit
austin-denoble File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,8 @@ jobs: | |
runs-on: ubuntu-latest | ||
outputs: | ||
serverlessIndexName: ${{ steps.step3.outputs.SERVERLESS_INDEX_NAME }} | ||
assistantName: ${{ steps.step3.outputs.ASSISTANT_NAME }} | ||
testFile: ${{ steps.step3.outputs.TEST_FILE }} | ||
steps: | ||
- name: Checkout code | ||
id: step1 | ||
|
@@ -23,8 +25,13 @@ jobs: | |
env: | ||
PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }} | ||
run: | | ||
SERVERLESS_INDEX_NAME=$(npx ts-node ./src/integration/setup.ts | grep "SERVERLESS_INDEX_NAME=" | cut -d'=' -f2) | ||
SETUP_OUTPUT=$(npx ts-node ./src/integration/setup.ts) | ||
SERVERLESS_INDEX_NAME=$(echo "$SETUP_OUTPUT" | grep "SERVERLESS_INDEX_NAME=" | cut -d'=' -f2) | ||
ASSISTANT_NAME=$(echo "$SETUP_OUTPUT" | grep "ASSISTANT_NAME=" | cut -d'=' -f2) | ||
TEST_FILE=$(echo "$SETUP_OUTPUT" | grep "TEST_FILE=" | cut -d'=' -f2) | ||
echo "SERVERLESS_INDEX_NAME=$SERVERLESS_INDEX_NAME" >> $GITHUB_OUTPUT | ||
echo "ASSISTANT_NAME=$ASSISTANT_NAME" >> $GITHUB_OUTPUT | ||
echo "TEST_FILE=$TEST_FILE" >> $GITHUB_OUTPUT | ||
|
||
unit-tests: | ||
needs: setup | ||
|
@@ -48,6 +55,8 @@ jobs: | |
runs-on: ubuntu-latest | ||
outputs: | ||
serverlessIndexName: ${{ steps.runTests1.outputs.SERVERLESS_INDEX_NAME }} | ||
assistantName: ${{ steps.runTests1.outputs.ASSISTANT_NAME }} | ||
testFile: ${{ steps.runTests1.outputs.TEST_FILE }} | ||
strategy: | ||
fail-fast: false | ||
max-parallel: 2 | ||
|
@@ -87,9 +96,13 @@ jobs: | |
CI: true | ||
PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }} | ||
SERVERLESS_INDEX_NAME: ${{ needs.setup.outputs.serverlessIndexName}} | ||
ASSISTANT_NAME: ${{ needs.setup.outputs.assistantName}} | ||
TEST_FILE: ${{ needs.setup.outputs.testFile}} | ||
run: | | ||
${{ matrix.config.runner }} run test:integration:${{ matrix.config.jest_env }} | ||
echo "SERVERLESS_INDEX_NAME=${{ needs.setup.outputs.serverlessIndexName}}" >> $GITHUB_OUTPUT | ||
echo "ASSISTANT_NAME=${{ needs.setup.outputs.assistantName}}" >> $GITHUB_OUTPUT | ||
echo "TEST_FILE=${{ needs.setup.outputs.testFile}}" >> $GITHUB_OUTPUT | ||
|
||
- name: Run integration tests (Staging) | ||
if: matrix.pinecone_env == 'staging' | ||
|
@@ -115,6 +128,8 @@ jobs: | |
env: | ||
PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }} | ||
SERVERLESS_INDEX_NAME: ${{ needs.integration-tests.outputs.serverlessIndexName}} | ||
ASSISTANT_NAME: ${{ needs.integration-tests.outputs.assistantName}} | ||
TEST_FILE: ${{ needs.integration-tests.outputs.testFile}} | ||
run: | | ||
npx ts-node ./src/integration/teardown.ts | ||
|
||
|
@@ -126,10 +141,6 @@ jobs: | |
matrix: | ||
tsVersion: | ||
[ | ||
'~4.1.0', | ||
'~4.2.0', | ||
'~4.3.0', | ||
'~4.4.0', | ||
'~4.5.0', | ||
'~4.6.0', | ||
'~4.7.0', | ||
|
@@ -138,6 +149,10 @@ jobs: | |
'~5.0.0', | ||
'~5.1.0', | ||
'~5.2.0', | ||
'~5.3.0', | ||
'~5.4.0', | ||
'~5.5.0', | ||
'~5.6.0', | ||
Comment on lines
+152
to
+155
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See this Slack thread for more color on this change |
||
'latest', | ||
] | ||
steps: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule apis
updated
from 3e5739 to 934bd7
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reviewers: You can ignore these diffs if you like. It's just me allowing CI to spin up a global Assistant and a file to play with.