Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Extract GrpcChannelFactory from GRPCIndexBase #394

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Oct 10, 2024

Problem

I'm preparing to implement asyncio for the data plane, and I had a need to extract some of this grpc channel configuration into a spot where it could be reused more easily across both sync and async implementations.

Solution

  • Extract GrpcChannelFactory from GRPCIndexBase
  • Add some unit tests for this new class

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: Refactoring only, should be no functional change

@jhamon jhamon marked this pull request as ready for review October 10, 2024 20:50
@jhamon jhamon merged commit 4c18899 into main Oct 11, 2024
84 of 85 checks passed
@jhamon jhamon deleted the jhamon/grpc-channel-refactor branch October 11, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants