Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios multiple flutter presenting error #1736

Conversation

AlexT84
Copy link
Contributor

@AlexT84 AlexT84 commented Aug 2, 2023

Connection with issue(s)

Resolve issue #???
This resolves the issue on iOS with the flutter_inappwebview used in multiple flutters native app.

Connected to #???

Testing and Review Notes

To test the fix just create a flutterViewController, flutter engine, load a flutter project in to a native tabbar app and try to use flutter_inappwebview from the flutter code.
The result will be that nothing will be presented to the user and te console will output:
[Presentation] Attempt to present <flutter_inappwebview.SafariViewController: 0x7fb4470ad200> on <Koala.RootNavigationController: 0x7fb4b4982e00> (from <Koala.RootNavigationController: 0x7fb4b4982e00>) whose view is not in the window hierarchy.

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@AlexT84 AlexT84 closed this Aug 2, 2023
@AlexT84 AlexT84 reopened this Aug 2, 2023
@pichillilorenzo pichillilorenzo merged commit 8c9a11d into pichillilorenzo:master Nov 10, 2023
1 check passed
@pichillilorenzo
Copy link
Owner

@all-contributors please add @AlexT84 for code

Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @AlexT84! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants