Element text selector: Normalize whitespace #3621
Open
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Make it easier to find an element by text (
element/3
,has_element?/3
) if there is nested markup.Example input:
Status quo:
element(view, "span", "Text\n with whitespace")
element(view, "span", ~r/Text\n.*with whitespace/)
With this PR:
element(view, "span", "Text with whitespace")
Solution: Normalize whitespace (convert different whitespace characters to regular space, collapse consecutive whitespace).
Breaking change: This PR changes the default behaviour. Maybe this should be opt-in instead?
Pointers
To feature test libraries, which of course can't be compared 1:1.
Wallaby
Playwright